Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Unified Diff: Source/core/rendering/RenderBlockFlow.cpp

Issue 834653003: [Slimming paint] [New Multicolumn] Repaint column rules when they change. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make the test useful. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/paint/MultiColumnSetPainter.cpp ('k') | Source/core/rendering/RenderMultiColumnFlowThread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderBlockFlow.cpp
diff --git a/Source/core/rendering/RenderBlockFlow.cpp b/Source/core/rendering/RenderBlockFlow.cpp
index 0d371aa66d299744b416c0eaf228cff9323deac4..2219e2261bdefdca37ef9ca87165493effcfaacf 100644
--- a/Source/core/rendering/RenderBlockFlow.cpp
+++ b/Source/core/rendering/RenderBlockFlow.cpp
@@ -1976,6 +1976,15 @@ void RenderBlockFlow::styleDidChange(StyleDifference diff, const RenderStyle* ol
if (diff.needsFullLayout() || !oldStyle)
createOrDestroyMultiColumnFlowThreadIfNeeded(oldStyle);
+ if (oldStyle) {
+ if (RenderMultiColumnFlowThread* flowThread = multiColumnFlowThread()) {
+ if (!style()->columnRuleEquivalent(oldStyle)) {
+ // Column rules are painted by anonymous column set children of the multicol
+ // container. We need to notify them.
+ flowThread->columnRuleStyleDidChange();
+ }
+ }
+ }
}
void RenderBlockFlow::updateBlockChildDirtyBitsBeforeLayout(bool relayoutChildren, RenderBox& child)
« no previous file with comments | « Source/core/paint/MultiColumnSetPainter.cpp ('k') | Source/core/rendering/RenderMultiColumnFlowThread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698