Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 834133004: Don't initialize C++ constants in Java during JNI registration. (Closed)

Created:
5 years, 11 months ago by mkosiba (inactive)
Modified:
5 years, 11 months ago
CC:
android-webview-reviews_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't initialize C++ constants in Java during JNI registration. This removes code which would perform one-time constant initialization during JNI registration. This is needed for the WebView which will use lazy JNI registration and not call these methods at all. BUG=436083 Committed: https://crrev.com/e890fe3c07256d41c2533cd5d5d7268752d2e2c2 Cr-Commit-Position: refs/heads/master@{#311089}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : fix aosp build #

Patch Set 5 : remove unnecessary @Deprecated #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : multi-line package name yet again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -150 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 4 chunks +5 lines, -5 lines 0 comments Download
M android_webview/java_library_common.mk View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M android_webview/libwebviewchromium.gypi View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/android/load_url_params.cc View 1 chunk +1 line, -20 lines 0 comments Download
M content/browser/renderer_host/ime_adapter_android.cc View 1 chunk +1 line, -21 lines 0 comments Download
M content/content.gyp View 2 chunks +10 lines, -0 lines 0 comments Download
M content/public/android/BUILD.gn View 1 3 chunks +4 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java View 1 5 chunks +8 lines, -6 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 1 8 chunks +12 lines, -53 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/LoadUrlParams.java View 1 2 3 4 13 chunks +19 lines, -43 lines 0 comments Download
M content/public/browser/navigation_controller.h View 1 2 3 4 5 6 7 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
mkosiba (inactive)
PTAL benm@ for content/public/android/ jochen@ for the rest
5 years, 11 months ago (2015-01-09 11:30:39 UTC) #2
jochen (gone - plz use gerrit)
i'm not a good reviewer for java related stuff.
5 years, 11 months ago (2015-01-09 13:07:12 UTC) #3
benm (inactive)
lgtm
5 years, 11 months ago (2015-01-09 14:04:25 UTC) #4
benm (inactive)
On 2015/01/09 14:04:25, benm wrote: > lgtm FYI: I looked over the whole change, and ...
5 years, 11 months ago (2015-01-09 14:05:33 UTC) #5
mkosiba (inactive)
On 2015/01/09 14:05:33, benm wrote: > On 2015/01/09 14:04:25, benm wrote: > > lgtm > ...
5 years, 11 months ago (2015-01-09 14:06:02 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-09 14:09:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834133004/80001
5 years, 11 months ago (2015-01-09 14:12:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/34490)
5 years, 11 months ago (2015-01-09 14:19:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834133004/100001
5 years, 11 months ago (2015-01-09 18:38:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834133004/120001
5 years, 11 months ago (2015-01-09 18:51:32 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/34600)
5 years, 11 months ago (2015-01-09 18:59:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834133004/140001
5 years, 11 months ago (2015-01-12 18:59:03 UTC) #19
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 11 months ago (2015-01-12 19:54:42 UTC) #20
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 19:55:34 UTC) #21
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/e890fe3c07256d41c2533cd5d5d7268752d2e2c2
Cr-Commit-Position: refs/heads/master@{#311089}

Powered by Google App Engine
This is Rietveld 408576698