Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2102)

Unified Diff: content/browser/renderer_host/ime_adapter_android.cc

Issue 834133004: Don't initialize C++ constants in Java during JNI registration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: multi-line package name yet again Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/android/load_url_params.cc ('k') | content/content.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/ime_adapter_android.cc
diff --git a/content/browser/renderer_host/ime_adapter_android.cc b/content/browser/renderer_host/ime_adapter_android.cc
index d780d0c8ff81c926361386b4deb8820647253e81..ac820f5765c3a7bf214293e8271e7bba7951f972 100644
--- a/content/browser/renderer_host/ime_adapter_android.cc
+++ b/content/browser/renderer_host/ime_adapter_android.cc
@@ -66,27 +66,7 @@ NativeWebKeyboardEvent NativeWebKeyboardEventFromKeyEvent(
} // anonymous namespace
bool RegisterImeAdapter(JNIEnv* env) {
- if (!RegisterNativesImpl(env))
- return false;
-
- Java_ImeAdapter_initializeWebInputEvents(env,
- blink::WebInputEvent::RawKeyDown,
- blink::WebInputEvent::KeyUp,
- blink::WebInputEvent::Char,
- blink::WebInputEvent::ShiftKey,
- blink::WebInputEvent::AltKey,
- blink::WebInputEvent::ControlKey,
- blink::WebInputEvent::CapsLockOn,
- blink::WebInputEvent::NumLockOn);
- Java_ImeAdapter_initializeTextInputFlags(
- env,
- blink::WebTextInputFlagAutocompleteOn,
- blink::WebTextInputFlagAutocompleteOff,
- blink::WebTextInputFlagAutocorrectOn,
- blink::WebTextInputFlagAutocorrectOff,
- blink::WebTextInputFlagSpellcheckOn,
- blink::WebTextInputFlagSpellcheckOff);
- return true;
+ return RegisterNativesImpl(env);
}
// Callback from Java to convert BackgroundColorSpan data to a
« no previous file with comments | « content/browser/android/load_url_params.cc ('k') | content/content.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698