content/browser/android/load_url_params.cc - Issue 834133004: Don't initialize C++ constants in Java during JNI registration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/load_url_params.cc

Issue 834133004: Don't initialize C++ constants in Java during JNI registration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: multi-line package name yet again Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc ('k') | content/browser/renderer_host/ime_adapter_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/load_url_params.cc

diff --git a/content/browser/android/load_url_params.cc b/content/browser/android/load_url_params.cc

index d276622f55a7e1799567d470b3ce503048532fde..67802ea0cfbdfbcb3e8e2e67baf2620b2bbc936b 100644

--- a/content/browser/android/load_url_params.cc

+++ b/content/browser/android/load_url_params.cc

@@ -12,29 +12,10 @@

#include "jni/LoadUrlParams_jni.h"

#include "url/gurl.h"

-namespace {

-using content::NavigationController;

-void RegisterConstants(JNIEnv* env) {

- Java_LoadUrlParams_initializeConstants(env,

- NavigationController::LOAD_TYPE_DEFAULT,

- NavigationController::LOAD_TYPE_BROWSER_INITIATED_HTTP_POST,

- NavigationController::LOAD_TYPE_DATA,

- NavigationController::UA_OVERRIDE_INHERIT,

- NavigationController::UA_OVERRIDE_FALSE,

- NavigationController::UA_OVERRIDE_TRUE);

-} // namespace

namespace content {

bool RegisterLoadUrlParams(JNIEnv* env) {

- if (!RegisterNativesImpl(env))

- return false;

- RegisterConstants(env);

- return true;

+ return RegisterNativesImpl(env);

}

jboolean IsDataScheme(JNIEnv* env, jclass clazz, jstring jurl) {