Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2075)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 834133004: Don't initialize C++ constants in Java during JNI registration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: multi-line package name yet again Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/java_library_common.mk » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/java/src/org/chromium/android_webview/AwContents.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java
index 3ee10deafe17e003768787f98b007027fe113eda..4d80be73e6d07d234a2cfeef69823b3e5675638d 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java
@@ -59,6 +59,8 @@ import org.chromium.content_public.browser.LoadUrlParams;
import org.chromium.content_public.browser.NavigationController;
import org.chromium.content_public.browser.NavigationHistory;
import org.chromium.content_public.browser.WebContents;
+import org.chromium.content_public.browser.navigation_controller.LoadURLType;
+import org.chromium.content_public.browser.navigation_controller.UserAgentOverrideOption;
import org.chromium.content_public.common.Referrer;
import org.chromium.ui.base.ActivityWindowAndroid;
import org.chromium.ui.base.PageTransition;
@@ -1151,8 +1153,7 @@ public class AwContents implements SmartClipProvider {
public void loadUrl(LoadUrlParams params) {
if (isDestroyed()) return;
- if (params.getLoadUrlType() == LoadUrlParams.LOAD_TYPE_DATA
- && !params.isBaseUrlDataScheme()) {
+ if (params.getLoadUrlType() == LoadURLType.DATA && !params.isBaseUrlDataScheme()) {
// This allows data URLs with a non-data base URL access to file:///android_asset/ and
// file:///android_res/ URLs. If AwSettings.getAllowFileAccess permits, it will also
// allow access to file:// URLs (subject to OS level permission checks).
@@ -1170,7 +1171,7 @@ public class AwContents implements SmartClipProvider {
// For WebView, always use the user agent override, which is set
// every time the user agent in AwSettings is modified.
- params.setOverrideUserAgent(LoadUrlParams.UA_OVERRIDE_TRUE);
+ params.setOverrideUserAgent(UserAgentOverrideOption.TRUE);
// We don't pass extra headers to the content layer, as WebViewClassic
@@ -1203,8 +1204,7 @@ public class AwContents implements SmartClipProvider {
requestVisitedHistoryFromClient();
}
- if (params.getLoadUrlType() == LoadUrlParams.LOAD_TYPE_DATA
- && params.getBaseUrl() != null) {
+ if (params.getLoadUrlType() == LoadURLType.DATA && params.getBaseUrl() != null) {
// Data loads with a base url will be resolved in Blink, and not cause an onPageStarted
// event to be sent. Sending the callback directly from here.
mContentsClient.getCallbackHelper().postOnPageStarted(params.getBaseUrl());
« no previous file with comments | « no previous file | android_webview/java_library_common.mk » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698