Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

Issue 831483003: [ServiceWorker] Use pageVisibilityState instead of visibilityState. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@page_visibility_state
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
diff --git a/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp b/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
index 481c8f18f11eda09fa0e0f6e8807269d30f4aa4f..f2e32cace38ea1cd4c48fae0989b64acfa2ab64e 100644
--- a/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
+++ b/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
@@ -171,7 +171,7 @@ protected:
m_page->document().setSecurityOrigin(SecurityOrigin::createFromString(url));
}
- void setVisibilityState(PageVisibilityState visibilityState)
+ void setPageVisibilityState(PageVisibilityState visibilityState)
{
m_page->page().setVisibilityState(visibilityState, true); // Set as initial state
}
@@ -364,7 +364,7 @@ TEST_F(ServiceWorkerContainerTest, GetRegistration_OmittedDocumentURLDefaultsToP
TEST_F(ServiceWorkerContainerTest, GetClientInfo)
{
- setVisibilityState(PageVisibilityStateVisible);
+ setPageVisibilityState(PageVisibilityStateVisible);
setFocused(true);
setPageURL("http://localhost/x/index.html");
@@ -372,15 +372,15 @@ TEST_F(ServiceWorkerContainerTest, GetClientInfo)
WebServiceWorkerClientInfo info;
ASSERT_TRUE(container->getClientInfo(&info));
- EXPECT_EQ(WebString("visible"), info.visibilityState);
+ EXPECT_EQ(WebPageVisibilityStateVisible, info.pageVisibilityState);
EXPECT_TRUE(info.isFocused);
EXPECT_EQ(WebURL(KURL(KURL(), "http://localhost/x/index.html")), info.url);
EXPECT_EQ(WebURLRequest::FrameTypeTopLevel, info.frameType);
- setVisibilityState(PageVisibilityStateHidden);
+ setPageVisibilityState(PageVisibilityStateHidden);
setFocused(false);
ASSERT_TRUE(container->getClientInfo(&info));
- EXPECT_EQ(WebString("hidden"), info.visibilityState);
+ EXPECT_EQ(WebPageVisibilityStateHidden, info.pageVisibilityState);
EXPECT_FALSE(info.isFocused);
}
« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerContainer.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerWindowClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698