Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1662)

Unified Diff: Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp

Issue 831483003: [ServiceWorker] Use pageVisibilityState instead of visibilityState. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@page_visibility_state
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp
diff --git a/Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp b/Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp
index e4987e5d74a753773b40e01291657df462d38dc5..2b9c6b01fe33e2209278d4bccc015b87156ae718 100644
--- a/Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp
+++ b/Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp
@@ -23,7 +23,6 @@ ServiceWorkerWindowClient* ServiceWorkerWindowClient::create(const WebServiceWor
ServiceWorkerWindowClient::ServiceWorkerWindowClient(const WebServiceWorkerClientInfo& info)
: ServiceWorkerClient(info)
- , m_visibilityState(info.visibilityState)
, m_pageVisibilityState(info.pageVisibilityState)
, m_isFocused(info.isFocused)
, m_frameType(info.frameType)
@@ -36,9 +35,6 @@ ServiceWorkerWindowClient::~ServiceWorkerWindowClient()
String ServiceWorkerWindowClient::visibilityState() const
{
- // FIXME: temporary until m_pageVisibilityState is used in Chromium.
- if (m_pageVisibilityState == WebPageVisibilityStateLast)
- return m_visibilityState;
return pageVisibilityStateString(static_cast<PageVisibilityState>(m_pageVisibilityState));
}
« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerWindowClient.h ('k') | public/platform/WebServiceWorkerClientsInfo.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698