Issue 829133003: Specs: custom element constructor argument shouldn't clash with the module-global 'module' identifi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 829133003: Specs: custom element constructor argument shouldn't clash with the module-global 'module' identifi… (Closed)

Created:
5 years, 11 months ago by Hixie

Modified:
5 years, 11 months ago

Reviewers:

CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Specs: custom element constructor argument shouldn't clash with the module-global 'module' identifier Committed: https://chromium.googlesource.com/external/mojo/+/fb4c00fb74871f4e0421d1b751fec3f489d4276e

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -29 lines)			Patch
M	sky/examples/calculator/buttons.sky	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	sky/examples/htmlish/framework/element.sky	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	sky/examples/radio.sky	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	sky/specs/modules.md	View	3 chunks	+18 lines, -13 lines	0 comments	Download
M	sky/specs/runloop.md	View	2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)

Hixie

5 years, 11 months ago (2015-01-07 22:40:02 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fb4c00fb74871f4e0421d1b751fec3f489d4276e.