Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: sky/examples/htmlish/framework/element.sky

Issue 829133003: Specs: custom element constructor argument shouldn't clash with the module-global 'module' identifi… (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/examples/calculator/buttons.sky ('k') | sky/examples/radio.sky » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/examples/htmlish/framework/element.sky
diff --git a/sky/examples/htmlish/framework/element.sky b/sky/examples/htmlish/framework/element.sky
index d2c1d1c1277dd4a1ec5e0f5b8f8e58eddd15f917..9df9c0dd02235cdf9c04e0c9508ff4b13588547d 100644
--- a/sky/examples/htmlish/framework/element.sky
+++ b/sky/examples/htmlish/framework/element.sky
@@ -22,10 +22,10 @@ SKY MODULE - defines an <element> element
module.exports.Element = sky.registerElement(
class extends Element {
static get tagName() { return 'element'; }
- constructor (module) {
- super();
+ constructor (hostModule) {
+ super(hostModule);
this.state = 'loading';
- this.module = module;
+ this.module = hostModule;
this.definedPrototype = sky.Element;
}
setPrototype(prototype) {
@@ -44,8 +44,8 @@ SKY MODULE - defines an <element> element
}
let tagName = this.getAttribute('name');
let constructorName = tagName.charAt(0).toUpperCase() + tagName.slice(1) + 'Element';
- let constructor = function (module) {
- super(module);
+ let constructor = function (hostModule) {
+ super(hostModule);
if (this.init)
this.init();
if (style)
« no previous file with comments | « sky/examples/calculator/buttons.sky ('k') | sky/examples/radio.sky » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698