Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1395)

Unified Diff: sky/examples/calculator/buttons.sky

Issue 829133003: Specs: custom element constructor argument shouldn't clash with the module-global 'module' identifi… (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/examples/htmlish/framework/element.sky » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/examples/calculator/buttons.sky
diff --git a/sky/examples/calculator/buttons.sky b/sky/examples/calculator/buttons.sky
index 29c59c35e44904adc918f7b387e0df04e6f891ae..07b32e010818ca325429750789fd8b00030ad91f 100644
--- a/sky/examples/calculator/buttons.sky
+++ b/sky/examples/calculator/buttons.sky
@@ -3,8 +3,8 @@ SKY MODULE - button widgets for calculator
<script>
class AbstractButton extends Element {
- constructor (module) {
- super(module);
+ constructor (hostModule) {
+ super(hostModule);
let selector = new SelectorQuery('.dynamic');
this.addEventListener('pointer-down', (event) => {
selector.findAll(this.shadowRoot).every((element) => element.setAttribute('clicked'));
@@ -59,8 +59,8 @@ SKY MODULE - button widgets for calculator
class extends AbstractButton {
static get tagName() { return 'graybutton'; }
static get shadow() { return true; }
- constructor (module) {
- super(module);
+ constructor (hostModule) {
+ super(hostModule);
this.shadowRoot.append(module.document.findId('threed-button-shadow-tree').cloneNode(true));
}
}
@@ -69,8 +69,8 @@ SKY MODULE - button widgets for calculator
class extends AbstractButton {
static get tagName() { return 'flatbutton'; }
static get shadow() { return true; }
- constructor (module) {
- super(module);
+ constructor (hostModule) {
+ super(hostModule);
this.shadowRoot.append(module.document.findId('flat-shadow-tree').cloneNode(true));
}
}
« no previous file with comments | « no previous file | sky/examples/htmlish/framework/element.sky » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698