Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: sky/examples/radio.sky

Issue 829133003: Specs: custom element constructor argument shouldn't clash with the module-global 'module' identifi… (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/examples/htmlish/framework/element.sky ('k') | sky/specs/modules.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/examples/radio.sky
diff --git a/sky/examples/radio.sky b/sky/examples/radio.sky
index 02c1f6a28e108a8d3b23b37f911560941f9abc84..3da67a0699551b18ecc3e358083f38af9274cf4f 100644
--- a/sky/examples/radio.sky
+++ b/sky/examples/radio.sky
@@ -13,8 +13,8 @@ SKY MODULE - radio button and radio button group
class extends Element {
static get tagName() { return 'radio'; }
static get shadow() { return true; }
- constructor (module) {
- super(module);
+ constructor (hostModule) {
+ super(hostModule);
this.addEventListener('click', (event) => this.checked = true);
this.shadowRoot.append(module.document.findId('radio-shadow').content.cloneNode(true));
}
@@ -53,8 +53,8 @@ SKY MODULE - radio button and radio button group
class extends Element {
static get tagName() { return 'radiogroup'; }
static get shadow() { return true; }
- constructor (module) {
- super(module);
+ constructor (hostModule) {
+ super(hostModule);
this.shadowRoot.append(module.document.findId('radiogroup-shadow').content.cloneNode(true));
}
get value () {
« no previous file with comments | « sky/examples/htmlish/framework/element.sky ('k') | sky/specs/modules.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698