Android Notifications should be closable without a delegate.

Android Notifications should be closable without a delegate.

When the browser process is started in response to a user interaction
with a Web Notification on Android, there may not be a delegate for
the given notification, which means that it cannot currently be closed.

In order to solve this, make sure the platform Id of a notification
is stored when the clicked on notification is not known to the browser
process yet (and thus was created by a previous session).

BUG=90795
Committed: https://crrev.com/69c51b0258bac059f652b271ac5b86daca8e05c2
Cr-Commit-Position: refs/heads/master@{#310787}

[Peter Beverloo, 2015-01-07 18:50:53]

peter@chromium.org changed reviewers:
+ dewittj@chromium.org, miguelg@chromium.org, mvanouwerkerk@chromium.org

[Peter Beverloo, 2015-01-07 18:50:53]

This patch depends on https://codereview.chromium.org/839533004/.

Tomorrow is test day. I promise. :-)

[Michael van Ouwerkerk, 2015-01-07 19:02:30]

lgtm

https://codereview.chromium.org/826883003/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java
(right):

https://codereview.chromium.org/826883003/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java:129:
|| !intent.hasExtra(NotificationConstants.EXTRA_NOTIFICATION_PLATFORM_ID)) {
indent seems unusual

[dewittj, 2015-01-08 01:06:17]

https://codereview.chromium.org/826883003/diff/1/chrome/browser/notifications...
File chrome/browser/notifications/notification_ui_manager_android.cc (right):

https://codereview.chromium.org/826883003/diff/1/chrome/browser/notifications...
chrome/browser/notifications/notification_ui_manager_android.cc:320: if
(platform_id_iter == platform_notifications_.end())
Can this code be consolidated with the common code in PlatformCloseNotification?

[Peter Beverloo, 2015-01-08 19:28:19]

https://codereview.chromium.org/826883003/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java
(right):

https://codereview.chromium.org/826883003/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java:129:
|| !intent.hasExtra(NotificationConstants.EXTRA_NOTIFICATION_PLATFORM_ID)) {
On 2015/01/07 19:02:30, Michael van Ouwerkerk wrote:
> indent seems unusual

It's the Java styleguide.. 8-space indent and || on the second line.

https://codereview.chromium.org/826883003/diff/1/chrome/browser/notifications...
File chrome/browser/notifications/notification_ui_manager_android.cc (right):

https://codereview.chromium.org/826883003/diff/1/chrome/browser/notifications...
chrome/browser/notifications/notification_ui_manager_android.cc:320: if
(platform_id_iter == platform_notifications_.end())
On 2015/01/08 01:06:17, dewittj wrote:
> Can this code be consolidated with the common code in
PlatformCloseNotification?

Oops, missed that! Thanks and done :-)

[dewittj, 2015-01-08 21:54:55]

lgtm

[Peter Beverloo, 2015-01-08 23:31:11]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2015-01-08 23:31:13]

The CQ bit was unchecked by peter@chromium.org

[Peter Beverloo, 2015-01-09 16:14:43]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2015-01-09 16:15:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/826883003/40001

[commit-bot: I haz the power, 2015-01-09 17:12:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-09 17:14:36]

Patchset 3 (id:??) landed as
https://crrev.com/69c51b0258bac059f652b271ac5b86daca8e05c2
Cr-Commit-Position: refs/heads/master@{#310787}