chrome/browser/notifications/notification_ui_manager_android.h - Issue 826883003: Android Notifications should be closable without a delegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_ui_manager_android.h

Issue 826883003: Android Notifications should be closable without a delegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a-serialize-pickle

Patch Set: rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java ('k') | chrome/browser/notifications/notification_ui_manager_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_ui_manager_android.h

diff --git a/chrome/browser/notifications/notification_ui_manager_android.h b/chrome/browser/notifications/notification_ui_manager_android.h

index 159aefc410d856b3ae711c5ac6103ae8e87b8e09..edaa97a2aaaab0e2fbd0367ae8738ebe03ab4686 100644

--- a/chrome/browser/notifications/notification_ui_manager_android.h

+++ b/chrome/browser/notifications/notification_ui_manager_android.h

@@ -26,6 +26,7 @@ class NotificationUIManagerAndroid : public NotificationUIManager {

bool OnNotificationClicked(JNIEnv* env,

jobject java_object,

jstring notification_id,

+ jint platform_id,

jbyteArray serialized_notification_data);

// Called by the Java implementation when a notification has been closed.

@@ -52,7 +53,7 @@ class NotificationUIManagerAndroid : public NotificationUIManager {

private:

// Closes the Notification as displayed on the Android system.

- void PlatformCloseNotification(ProfileNotification* profile_notification);

+ void PlatformCloseNotification(const std::string& notification_id);

// Helpers that add/remove the notification from local map.

// The local map takes ownership of profile_notification object.