chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java - Issue 826883003: Android Notifications should be closable without a delegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

Issue 826883003: Android Notifications should be closable without a delegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a-serialize-pickle

Patch Set: rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

index 674568dd5a5fdd49661d6d3ec46175aa3e24d739..b5aa541e6484a8219fb7365bcae380a7f712e143 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java

@@ -15,6 +15,10 @@ public class NotificationConstants {

"org.chromium.chrome.browser.notifications.CLOSE_NOTIFICATION";

public static final String EXTRA_NOTIFICATION_ID = "notification_id";

+ // TODO(peter): Remove these extras once Notifications are powered by a database on the

+ // native side, that contains all the additional information.

+ public static final String EXTRA_NOTIFICATION_PLATFORM_ID = "notification_platform_id";

public static final String EXTRA_NOTIFICATION_DATA = "notification_data";

/**

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java » ('j') | no next file with comments »