Android Notifications should be closable without a delegate.

chrome/browser/notifications/notification_ui_manager_android.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/notification_ui_manager_android.h"
 
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/logging.h"
 #include "base/pickle.h"
@@ skipping 126 matching lines @@
 
 NotificationUIManagerAndroid::~NotificationUIManagerAndroid() {
   Java_NotificationUIManager_destroy(AttachCurrentThread(),
                                      java_object_.obj());
 }
 
 bool NotificationUIManagerAndroid::OnNotificationClicked(
     JNIEnv* env,
     jobject java_object,
     jstring notification_id,
+    jint platform_id,
     jbyteArray serialized_notification_data) {
   std::string id = ConvertJavaStringToUTF8(env, notification_id);
 
   auto iter = profile_notifications_.find(id);
   if (iter != profile_notifications_.end()) {
     const Notification& notification = iter->second->notification();
     notification.delegate()->Click();
 
     return true;
   }
@@ skipping 12 matching lines @@
   content::PlatformNotificationData notification_data;
   GURL origin;
   int64 service_worker_registration_id;
 
   Pickle pickle(reinterpret_cast<const char*>(&bytes[0]), bytes.size());
   if (!UnserializePersistentNotification(pickle, &notification_data, &origin,
                                          &service_worker_registration_id)) {
     return false;
   }
 
+  // Store the platform Id of this notification so that it can be closed.
+  platform_notifications_[id] = platform_id;
+
   PlatformNotificationServiceImpl* service =
       PlatformNotificationServiceImpl::GetInstance();
 
   // TODO(peter): Rather than assuming that the last used profile is the
   // appropriate one for this notification, the used profile should be
   // stored as part of the notification's data. See https://crbug.com/437574.
   service->OnPersistentNotificationClick(
       ProfileManager::GetLastUsedProfile(),
       service_worker_registration_id,
       id,
@@ skipping 108 matching lines @@
 
   return &profile_notification->notification();
 }
 
 bool NotificationUIManagerAndroid::CancelById(const std::string& delegate_id,
                                               ProfileID profile_id) {
   std::string profile_notification_id =
       ProfileNotification::GetProfileNotificationId(delegate_id, profile_id);
   ProfileNotification* profile_notification =
       FindProfileNotification(profile_notification_id);
-  if (!profile_notification)
+  if (profile_notification) {
+    RemoveProfileNotification(profile_notification);
+    return true;
+  }
+
+  // On Android, it's still possible that the notification can be closed in case
+  // the platform Id is known, even if no delegate exists. This happens when the
+  // browser process is started because of interaction with a Notification.
+  auto platform_id_iter = platform_notifications_.find(delegate_id);
+  if (platform_id_iter == platform_notifications_.end())

[dewittj, 2015/01/08 01:06:17]

Can this code be consolidated with the common code in PlatformCloseNotification?

[Peter Beverloo, 2015/01/08 19:28:19]

Oops, missed that! Thanks and done :-)

     return false;
 
-  RemoveProfileNotification(profile_notification);
+  Java_NotificationUIManager_closeNotification(AttachCurrentThread(),
+                                               java_object_.obj(),
+                                               platform_id_iter->second);
+
+  platform_notifications_.erase(platform_id_iter);
+
   return true;
 }
 
 std::set<std::string>
 NotificationUIManagerAndroid::GetAllIdsByProfileAndSourceOrigin(
     Profile* profile,
     const GURL& source) {
   // |profile| may be invalid, so no calls must be made based on the instance.
   std::set<std::string> delegate_ids;
 
@@ skipping 96 matching lines @@
 
 ProfileNotification* NotificationUIManagerAndroid::FindProfileNotification(
     const std::string& id) const {
   auto iter = profile_notifications_.find(id);
   if (iter == profile_notifications_.end())
     return nullptr;
 
   return iter->second;
 }