Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 824783004: Fix string escaping in (un)install scripts of native messaging example (Closed)

Created:
5 years, 11 months ago by robwu
Modified:
5 years, 11 months ago
Reviewers:
Sergey Ulanov, scheib
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix string escaping in (un)install scripts of native messaging example NOTRY=true BUG=401797 R= sergeyu@chromium.org Committed: https://crrev.com/25a73d005e46ac0b9e8499e4c51f8c6305b56e87 Cr-Commit-Position: refs/heads/master@{#310106}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M chrome/common/extensions/docs/examples/api/nativeMessaging/host/install_host.sh View 1 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/nativeMessaging/host/uninstall_host.sh View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
robwu
5 years, 11 months ago (2015-01-06 10:10:28 UTC) #1
Sergey Ulanov
LGTM, thank you! +scheib@ for OWNERS approval https://codereview.chromium.org/824783004/diff/1/chrome/common/extensions/docs/examples/api/nativeMessaging/host/install_host.sh File chrome/common/extensions/docs/examples/api/nativeMessaging/host/install_host.sh (right): https://codereview.chromium.org/824783004/diff/1/chrome/common/extensions/docs/examples/api/nativeMessaging/host/install_host.sh#newcode26 chrome/common/extensions/docs/examples/api/nativeMessaging/host/install_host.sh:26: mkdir -p ...
5 years, 11 months ago (2015-01-06 17:29:59 UTC) #3
scheib
lgtm
5 years, 11 months ago (2015-01-06 17:40:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824783004/20001
5 years, 11 months ago (2015-01-06 17:44:01 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-06 17:44:55 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 17:45:34 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/25a73d005e46ac0b9e8499e4c51f8c6305b56e87
Cr-Commit-Position: refs/heads/master@{#310106}

Powered by Google App Engine
This is Rietveld 408576698