chrome/common/extensions/docs/examples/api/nativeMessaging/host/uninstall_host.sh - Issue 824783004: Fix string escaping in (un)install scripts of native messaging example

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/examples/api/nativeMessaging/host/uninstall_host.sh

Issue 824783004: Fix string escaping in (un)install scripts of native messaging example (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/docs/examples/api/nativeMessaging/host/uninstall_host.sh

diff --git a/chrome/common/extensions/docs/examples/api/nativeMessaging/host/uninstall_host.sh b/chrome/common/extensions/docs/examples/api/nativeMessaging/host/uninstall_host.sh

index 5fc4d4c727aa543077e09c40d3a4cdc73adb9c50..db6b73df890cf157ceaa5d5ca73e6ca161403ed4 100755

--- a/chrome/common/extensions/docs/examples/api/nativeMessaging/host/uninstall_host.sh

+++ b/chrome/common/extensions/docs/examples/api/nativeMessaging/host/uninstall_host.sh

@@ -5,21 +5,20 @@

set -e

-if [ $(uname -s) == 'Darwin' ]; then

+if [ "$(uname -s)" == "Darwin" ]; then

if [ "$(whoami)" == "root" ]; then

TARGET_DIR="/Library/Google/Chrome/NativeMessagingHosts"

else

- TARGET_DIR=\

- "$HOME/Library/Application Support/Google/Chrome/NativeMessagingHosts"

+ TARGET_DIR="$HOME/Library/Application Support/Google/Chrome/NativeMessagingHosts"

else

if [ "$(whoami)" == "root" ]; then

TARGET_DIR="/etc/opt/chrome/native-messaging-hosts"

else

- TARGET_DIR='$HOME/.config/google-chrome/NativeMessagingHosts'

+ TARGET_DIR="$HOME/.config/google-chrome/NativeMessagingHosts"

HOST_NAME=com.google.chrome.example.echo

-rm $TARGET_DIR/com.google.chrome.example.echo.json

-echo Native messaging host $HOST_NAME has been uninstalled.

+rm "$TARGET_DIR/com.google.chrome.example.echo.json"

+echo "Native messaging host $HOST_NAME has been uninstalled."

« no previous file with comments | « chrome/common/extensions/docs/examples/api/nativeMessaging/host/install_host.sh ('k') | no next file » | no next file with comments »