Fix string escaping on OS X paths

Fix string escaping on OS X paths

Currently, unless you install as root, "Application Support" exists in the path, and the space borks everything up.

Committed: https://crrev.com/8249145b13b4893f0de507cbe26de72dd7ffbd79
Cr-Commit-Position: refs/heads/master@{#310013}

[Patrick Kettner, 2014-09-14 05:19:10]

patrickkettner@gmail.com changed reviewers:
+ sergeyu@chromium.org

[Sergey Ulanov, 2014-09-20 17:50:04]

https://codereview.chromium.org/569083002/diff/1/chrome/common/extensions/doc...
File
chrome/common/extensions/docs/examples/api/nativeMessaging/host/install_host.sh
(right):

https://codereview.chromium.org/569083002/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/nativeMessaging/host/install_host.sh:14:
$HOME/Library/Application Support/Google/Chrome/NativeMessagingHosts"
This adds spaces in TARGET_DIR, do I don't think you need this change

[Patrick Kettner, 2014-09-20 18:00:57]

https://codereview.chromium.org/569083002/diff/1/chrome/common/extensions/doc...
File
chrome/common/extensions/docs/examples/api/nativeMessaging/host/install_host.sh
(right):

https://codereview.chromium.org/569083002/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/nativeMessaging/host/install_host.sh:14:
$HOME/Library/Application Support/Google/Chrome/NativeMessagingHosts"
On 2014/09/20 17:50:04, Sergey Ulanov wrote:
> This adds spaces in TARGET_DIR, do I don't think you need this change 

It does add a space, however that space doesn't change anything since all of the
commands ignore multiple sequential spaces.  

The change was required because the newline followed by the leading spaces on
the script cause the shell to try and execute the path. At least on my zsh (zsh
5.0.6 (x86_64-apple-darwin14.0.0)) and bash (GNU bash, version 4.3.24(1)-release
(x86_64-apple-darwin14.0.0))

An alternative would be to scrunch line 14 against the far left with no leading
spaces, but that seemed an uglier fix.

[Sergey Ulanov, 2014-09-25 18:02:54]

Ok, this change looks good.
Can you please add yourself src/AUTHORS file in this CL?

[Patrick Kettner, 2014-10-21 03:42:22]

On 2014/09/25 18:02:54, Sergey Ulanov wrote:
> Ok, this change looks good.
> Can you please add yourself src/AUTHORS file in this CL?

Please excuse my ignorance, but since originally opening this PR, my laptop's
harddrive died and I had to reclone. As a result, I am not sure how to modify
this. Could you either let me know or point me to some kind of documentation?

Thanks a lot, and sorry for the trouble.

[Sergey Ulanov, 2014-12-10 21:05:12]

On 2014/10/21 03:42:22, Patrick Kettner wrote:
> On 2014/09/25 18:02:54, Sergey Ulanov wrote:
> > Ok, this change looks good.
> > Can you please add yourself src/AUTHORS file in this CL?
> 
> Please excuse my ignorance, but since originally opening this PR, my laptop's
> harddrive died and I had to reclone. As a result, I am not sure how to modify
> this. Could you either let me know or point me to some kind of documentation?
> 
> Thanks a lot, and sorry for the trouble.

Sorry for the delay, I was away for the last 2 months.
You can do "git cl patch 569083002" and then "git cl issue 569083002" to apply
this patch and then associate that branch with this CL.

[patrickkettner_gmail.com, 2014-12-29 04:28:17]

Thanks so much for the help!
Updated the AUTHORS file

On Wed, Dec 10, 2014 at 4:05 PM, <sergeyu@chromium.org> wrote:

> On 2014/10/21 03:42:22, Patrick Kettner wrote:
>
>> On 2014/09/25 18:02:54, Sergey Ulanov wrote:
>> > Ok, this change looks good.
>> > Can you please add yourself src/AUTHORS file in this CL?
>>
>
>  Please excuse my ignorance, but since originally opening this PR, my
>> laptop's
>> harddrive died and I had to reclone. As a result, I am not sure how to
>> modify
>> this. Could you either let me know or point me to some kind of
>> documentation?
>>
>
>  Thanks a lot, and sorry for the trouble.
>>
>
> Sorry for the delay, I was away for the last 2 months.
> You can do "git cl patch 569083002" and then "git cl issue 569083002" to
> apply
> this patch and then associate that branch with this CL.
>
> https://codereview.chromium.org/569083002/
>



-- 
patrick

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Sergey Ulanov, 2015-01-05 22:15:00]

LGTM, Thanks!

[Sergey Ulanov, 2015-01-05 22:15:04]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2015-01-05 22:15:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/569083002/20001

[commit-bot: I haz the power, 2015-01-05 22:24:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-05 22:24:51]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[patrickkettner_gmail.com, 2015-01-05 22:36:14]

I *believe* the failure is "Missing LGTM from an OWNER for these
files:
chrome/common/extensions/docs/examples/api/nativeMessaging/host/install_host.sh",
right? Do I need to contact someone to get a sign off?

On Mon, Jan 5, 2015 at 5:24 PM, <commit-bot@chromium.org> wrote:

> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux
> (http://build.chromium.org/p/tryserver.chromium.linux/
> builders/chromium_presubmit/builds/33227)
>
> https://codereview.chromium.org/569083002/
>



-- 
patrick

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Sergey Ulanov, 2015-01-05 23:23:26]

sergeyu@chromium.org changed reviewers:
+ scheib@chromium.org

[Sergey Ulanov, 2015-01-05 23:23:26]

+scheib@, can you please approve this fix?

[scheib, 2015-01-06 00:03:06]

lgtm

[Sergey Ulanov, 2015-01-06 00:11:47]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2015-01-06 00:12:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/569083002/20001

[commit-bot: I haz the power, 2015-01-06 00:53:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-06 00:54:16]

Patchset 2 (id:??) landed as
https://crrev.com/8249145b13b4893f0de507cbe26de72dd7ffbd79
Cr-Commit-Position: refs/heads/master@{#310013}