Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: chrome/common/extensions/docs/examples/api/nativeMessaging/host/install_host.sh

Issue 824783004: Fix string escaping in (un)install scripts of native messaging example (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/docs/examples/api/nativeMessaging/host/uninstall_host.sh » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/bin/sh 1 #!/bin/sh
2 # Copyright 2013 The Chromium Authors. All rights reserved. 2 # Copyright 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 set -e 6 set -e
7 7
8 DIR="$( cd "$( dirname "$0" )" && pwd )" 8 DIR="$( cd "$( dirname "$0" )" && pwd )"
9 if [ $(uname -s) == 'Darwin' ]; then 9 if [ "$(uname -s)" == "Darwin" ]; then
10 if [ "$(whoami)" == "root" ]; then 10 if [ "$(whoami)" == "root" ]; then
11 TARGET_DIR="/Library/Google/Chrome/NativeMessagingHosts" 11 TARGET_DIR="/Library/Google/Chrome/NativeMessagingHosts"
12 else 12 else
13 TARGET_DIR=" 13 TARGET_DIR="$HOME/Library/Application Support/Google/Chrome/NativeMessagingH osts"
14 $HOME/Library/Application Support/Google/Chrome/NativeMessagingHosts"
15 fi 14 fi
16 else 15 else
17 if [ "$(whoami)" == "root" ]; then 16 if [ "$(whoami)" == "root" ]; then
18 TARGET_DIR="/etc/opt/chrome/native-messaging-hosts" 17 TARGET_DIR="/etc/opt/chrome/native-messaging-hosts"
19 else 18 else
20 TARGET_DIR="$HOME/.config/google-chrome/NativeMessagingHosts" 19 TARGET_DIR="$HOME/.config/google-chrome/NativeMessagingHosts"
21 fi 20 fi
22 fi 21 fi
23 22
24 HOST_NAME=com.google.chrome.example.echo 23 HOST_NAME=com.google.chrome.example.echo
25 24
26 # Create directory to store native messaging host. 25 # Create directory to store native messaging host.
27 mkdir -p "$TARGET_DIR" 26 mkdir -p "$TARGET_DIR"
28 27
29 # Copy native messaging host manifest. 28 # Copy native messaging host manifest.
30 cp $DIR/$HOST_NAME.json "$TARGET_DIR" 29 cp "$DIR/$HOST_NAME.json" "$TARGET_DIR"
31 30
32 # Update host path in the manifest. 31 # Update host path in the manifest.
33 HOST_PATH=$DIR/native-messaging-example-host 32 HOST_PATH=$DIR/native-messaging-example-host
34 ESCAPED_HOST_PATH=${HOST_PATH////\\/} 33 ESCAPED_HOST_PATH=${HOST_PATH////\\/}
35 sed -i -e "s/HOST_PATH/$ESCAPED_HOST_PATH/" "$TARGET_DIR/$HOST_NAME.json" 34 sed -i -e "s/HOST_PATH/$ESCAPED_HOST_PATH/" "$TARGET_DIR/$HOST_NAME.json"
36 35
37 # Set permissions for the manifest so that all users can read it. 36 # Set permissions for the manifest so that all users can read it.
38 chmod o+r "$TARGET_DIR/$HOST_NAME.json" 37 chmod o+r "$TARGET_DIR/$HOST_NAME.json"
39 38
40 echo Native messaging host $HOST_NAME has been installed. 39 echo "Native messaging host $HOST_NAME has been installed."
OLDNEW
« no previous file with comments | « no previous file | chrome/common/extensions/docs/examples/api/nativeMessaging/host/uninstall_host.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698