Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 824513003: Standardize usage of virtual/override/final specifiers in components/. (Closed)

Created:
6 years ago by dcheng
Modified:
5 years, 11 months ago
CC:
browser-components-watch_chromium.org, chromium-reviews, darin-cc_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, jam, maniscalco+watch_chromium.org, maxbogue+watch_chromium.org, mkwst+watchlist-passwords_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, pvalenzuela+watch_chromium.org, rouslan+autofillwatch_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final specifiers in components/. The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. Several formatting edits by clang-format were manually reverted, due to mangling of some of the more complicate IPC macros. BUG=417463 TBR=blundell@chromium.org Committed: https://crrev.com/6a89b90150b02f7a2c7f56faf9913eaf40f6de17 Cr-Commit-Position: refs/heads/master@{#309781}

Patch Set 1 #

Patch Set 2 : Simplify #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -50 lines) Patch
M components/autofill/core/browser/autofill_metrics_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc View 1 2 1 chunk +1 line, -8 lines 0 comments Download
M components/dom_distiller/content/web_contents_main_frame_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/core/dom_distiller_store.h View 1 chunk +5 lines, -6 lines 0 comments Download
M components/domain_reliability/monitor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/domain_reliability/util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/google/core/browser/google_url_tracker_map_entry.h View 1 chunk +1 line, -1 line 0 comments Download
M components/infobars/core/infobar_container.h View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/histogram_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_form_manager_unittest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M components/password_manager/core/browser/password_store.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_account_token_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_account_token_fetcher_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_client_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/renderer_context_menu/render_view_context_menu_base.h View 1 chunk +2 lines, -3 lines 0 comments Download
M components/suggestions/suggestions_service_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/sync_driver/non_ui_data_type_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/translate/content/renderer/renderer_cld_data_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M components/wallpaper/wallpaper_manager_base.h View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
dcheng
6 years ago (2014-12-22 21:50:22 UTC) #2
dcheng
+caitkp instead
5 years, 11 months ago (2014-12-29 18:14:19 UTC) #4
dcheng
+thakis to get this moving along.
5 years, 11 months ago (2014-12-29 20:25:13 UTC) #6
Nico
lgtm https://codereview.chromium.org/824513003/diff/20001/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc File components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc (right): https://codereview.chromium.org/824513003/diff/20001/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc#newcode29 components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc:29: typedef net::NetworkDelegateImpl TestNetworkDelegate; using TestNetworkDelegate = net::NetworkDelegateImpl; :-P
5 years, 11 months ago (2014-12-29 22:17:40 UTC) #7
dcheng
https://codereview.chromium.org/824513003/diff/20001/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc File components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc (right): https://codereview.chromium.org/824513003/diff/20001/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc#newcode29 components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc:29: typedef net::NetworkDelegateImpl TestNetworkDelegate; On 2014/12/29 22:17:40, Nico wrote: > ...
5 years, 11 months ago (2014-12-29 23:39:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824513003/40001
5 years, 11 months ago (2014-12-29 23:40:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/32737)
5 years, 11 months ago (2014-12-29 23:46:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824513003/40001
5 years, 11 months ago (2014-12-30 19:58:02 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/19270)
5 years, 11 months ago (2014-12-30 21:08:25 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824513003/40001
5 years, 11 months ago (2014-12-30 21:09:57 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2014-12-30 21:41:27 UTC) #20
commit-bot: I haz the power
5 years, 11 months ago (2014-12-30 21:43:11 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6a89b90150b02f7a2c7f56faf9913eaf40f6de17
Cr-Commit-Position: refs/heads/master@{#309781}

Powered by Google App Engine
This is Rietveld 408576698