components/dom_distiller/core/dom_distiller_store.h - Issue 824513003: Standardize usage of virtual/override/final specifiers in components/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/core/dom_distiller_store.h

Issue 824513003: Standardize usage of virtual/override/final specifiers in components/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/content/web_contents_main_frame_observer_unittest.cc ('k') | components/domain_reliability/monitor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/core/dom_distiller_store.h

diff --git a/components/dom_distiller/core/dom_distiller_store.h b/components/dom_distiller/core/dom_distiller_store.h

index 4eda8391184dc2fd7c2b47bb61b4eee853f1b339..103d43e237ae3c24f05493f404996ff1e8935587 100644

--- a/components/dom_distiller/core/dom_distiller_store.h

+++ b/components/dom_distiller/core/dom_distiller_store.h

@@ -126,12 +126,11 @@ class DomDistillerStore : public syncer::SyncableService,

bool UpdateEntry(const ArticleEntry& entry) override;

bool RemoveEntry(const ArticleEntry& entry) override;

- virtual void UpdateAttachments(

- const std::string& entry_id,

- scoped_ptr<ArticleAttachmentsData> attachments_data,

- const UpdateAttachmentsCallback& callback) override;

- virtual void GetAttachments(const std::string& entry_id,

- const GetAttachmentsCallback& callback) override;

+ void UpdateAttachments(const std::string& entry_id,

+ scoped_ptr<ArticleAttachmentsData> attachments_data,

+ const UpdateAttachmentsCallback& callback) override;

+ void GetAttachments(const std::string& entry_id,

+ const GetAttachmentsCallback& callback) override;

bool GetEntryById(const std::string& entry_id, ArticleEntry* entry) override;

bool GetEntryByUrl(const GURL& url, ArticleEntry* entry) override;