components/sync_driver/non_ui_data_type_controller.h - Issue 824513003: Standardize usage of virtual/override/final specifiers in components/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/non_ui_data_type_controller.h

Issue 824513003: Standardize usage of virtual/override/final specifiers in components/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/suggestions/suggestions_service_unittest.cc ('k') | components/translate/content/renderer/renderer_cld_data_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/non_ui_data_type_controller.h

diff --git a/components/sync_driver/non_ui_data_type_controller.h b/components/sync_driver/non_ui_data_type_controller.h

index 45cee429a88ddf364713951d3e7fae011539637a..82f2eb1cb21570311299fbe0c4acb2ad79e0dbd2 100644

--- a/components/sync_driver/non_ui_data_type_controller.h

+++ b/components/sync_driver/non_ui_data_type_controller.h

@@ -33,8 +33,8 @@ class NonUIDataTypeController : public DataTypeController {

void LoadModels(const ModelLoadCallback& model_load_callback) override;

void StartAssociating(const StartCallback& start_callback) override;

void Stop() override;

- virtual syncer::ModelType type() const = 0;

- virtual syncer::ModelSafeGroup model_safe_group() const = 0;

+ syncer::ModelType type() const override = 0;

+ syncer::ModelSafeGroup model_safe_group() const override = 0;

ChangeProcessor* GetChangeProcessor() const override;

std::string name() const override;

State state() const override;