Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Side by Side Diff: components/renderer_context_menu/render_view_context_menu_base.h

Issue 824513003: Standardize usage of virtual/override/final specifiers in components/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_RENDERER_CONTEXT_MENU_RENDER_VIEW_CONTEXT_MENU_BASE_H_ 5 #ifndef COMPONENTS_RENDERER_CONTEXT_MENU_RENDER_VIEW_CONTEXT_MENU_BASE_H_
6 #define COMPONENTS_RENDERER_CONTEXT_MENU_RENDER_VIEW_CONTEXT_MENU_BASE_H_ 6 #define COMPONENTS_RENDERER_CONTEXT_MENU_RENDER_VIEW_CONTEXT_MENU_BASE_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 virtual void RecordUsedItem(int id) = 0; 133 virtual void RecordUsedItem(int id) = 0;
134 134
135 // Increments histogram value for visible context menu item specified by |id|. 135 // Increments histogram value for visible context menu item specified by |id|.
136 virtual void RecordShownItem(int id) = 0; 136 virtual void RecordShownItem(int id) = 0;
137 137
138 #if defined(ENABLE_PLUGINS) 138 #if defined(ENABLE_PLUGINS)
139 virtual void HandleAuthorizeAllPlugins() = 0; 139 virtual void HandleAuthorizeAllPlugins() = 0;
140 #endif 140 #endif
141 141
142 // Returns the accelerator for given |command_id|. 142 // Returns the accelerator for given |command_id|.
143 virtual bool GetAcceleratorForCommandId( 143 bool GetAcceleratorForCommandId(int command_id,
144 int command_id, 144 ui::Accelerator* accelerator) override = 0;
145 ui::Accelerator* accelerator) = 0;
146 145
147 // Subclasses should send notification. 146 // Subclasses should send notification.
148 virtual void NotifyMenuShown() = 0; 147 virtual void NotifyMenuShown() = 0;
149 virtual void NotifyURLOpened(const GURL& url, 148 virtual void NotifyURLOpened(const GURL& url,
150 content::WebContents* new_contents) = 0; 149 content::WebContents* new_contents) = 0;
151 150
152 // TODO(oshima): Remove this. 151 // TODO(oshima): Remove this.
153 virtual void AppendPlatformEditableItems() {} 152 virtual void AppendPlatformEditableItems() {}
154 153
155 content::RenderFrameHost* GetRenderFrameHost(); 154 content::RenderFrameHost* GetRenderFrameHost();
(...skipping 29 matching lines...) Expand all
185 184
186 // The RenderFrameHost's IDs. 185 // The RenderFrameHost's IDs.
187 int render_process_id_; 186 int render_process_id_;
188 187
189 scoped_ptr<ToolkitDelegate> toolkit_delegate_; 188 scoped_ptr<ToolkitDelegate> toolkit_delegate_;
190 189
191 DISALLOW_COPY_AND_ASSIGN(RenderViewContextMenuBase); 190 DISALLOW_COPY_AND_ASSIGN(RenderViewContextMenuBase);
192 }; 191 };
193 192
194 #endif // COMPONENTS_RENDERER_CONTEXT_MENU_RENDER_VIEW_CONTEXT_MENU_BASE_H_ 193 #endif // COMPONENTS_RENDERER_CONTEXT_MENU_RENDER_VIEW_CONTEXT_MENU_BASE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698