Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 823123003: Delete PaintInvalidationState. It's unused. (Closed)

Created:
5 years, 11 months ago by ojan
Modified:
5 years, 11 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Delete PaintInvalidationState. It's unused. Delete selection paint invalidation code. There is a slight change in behavior in FrameSelection::revealSelection. If you have a non-collapsed selection, then we'll center the start of the selection instead of the whole selection in some cases. There's a ton of callers of this code, so it's hard to be sure if any of this actually changes behavior for sky. In manual testing, I couldn't find any scenarios where there was a difference. Almost universally, when we call revealSelection, we have a CaretSelection. The only case I could think of where we have a RangeSelection is when modifying an off-screen selection (e.g. shift+right), but in that case we pass the RevealExtent option, so this patch doesn't change behavior there. Removing that caller makes all the rest of this rect computing code into dead code. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/cbd33628df59e51aac535c2c5daa8fd5f0eedd33

Patch Set 1 #

Patch Set 2 : proper diff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -248 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/LayoutState.h View 2 chunks +0 lines, -3 lines 0 comments Download
D sky/engine/core/rendering/PaintInvalidationState.h View 1 chunk +0 lines, -63 lines 0 comments Download
D sky/engine/core/rendering/PaintInvalidationState.cpp View 1 chunk +0 lines, -95 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 1 1 chunk +1 line, -9 lines 0 comments Download
M sky/engine/core/rendering/RenderInline.h View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderInline.cpp View 1 2 chunks +2 lines, -10 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 1 5 chunks +2 lines, -8 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 4 chunks +4 lines, -14 lines 0 comments Download
M sky/engine/core/rendering/RenderView.h View 1 4 chunks +1 line, -30 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
This depends on https://codereview.chromium.org/847303003
5 years, 11 months ago (2015-01-14 21:18:42 UTC) #1
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-14 21:20:45 UTC) #3
ojan
5 years, 11 months ago (2015-01-14 21:25:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cbd33628df59e51aac535c2c5daa8fd5f0eedd33 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698