Delete selection paint invalidation code.

Delete selection paint invalidation code.

There is a slight change in behavior in FrameSelection::revealSelection.
If you have a non-collapsed selection, then we'll center the start
of the selection instead of the whole selection in some cases. There's
a ton of callers of this code, so it's hard to be sure if any of this
actually changes behavior for sky. In manual testing, I couldn't find
any scenarios where there was a difference. Almost universally,
when we call revealSelection, we have a CaretSelection. The only
case I could think of where we have a RangeSelection is when
modifying an off-screen selection (e.g. shift+right), but in that case
we pass the RevealExtent option, so this patch doesn't change behavior
there.

Removing that caller makes all the rest of this rect computing
code into dead code.

R=abarth@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/550791f3f907423412a28d4dec81467ce81cc67c

[ojan, 2015-01-14 19:49:18]

ojan@chromium.org changed reviewers:
+ abarth@chromium.org, eseidel@chromium.org, esprehn@chromium.org

[ojan, 2015-01-14 19:49:19]

https://codereview.chromium.org/847303003/diff/1/sky/engine/core/editing/Fram...
File sky/engine/core/editing/FrameSelection.cpp (right):

https://codereview.chromium.org/847303003/diff/1/sky/engine/core/editing/Fram...
sky/engine/core/editing/FrameSelection.cpp:1534: Position position =
revealExtentOption == RevealExtent ? extent() : base();
This is the only change in behavior. The rest of this patch is all deleting dead
code.

[abarth-chromium, 2015-01-14 21:21:15]

lgtm

[ojan, 2015-01-14 21:25:23]

Committed patchset #1 (id:1) manually as
550791f3f907423412a28d4dec81467ce81cc67c (presubmit successful).