Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 822923002: [turbofan] Cache float32 constants on the JSGraph level. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Cache float32 constants on the JSGraph level. Also slightly refactor the NodeCache and CommonNodeCache classes to reduce inherent overhead of caching. TEST=cctest Committed: https://crrev.com/4f9193e047d50b1ffbca95e8185576af82c722b3 Cr-Commit-Position: refs/heads/master@{#25937}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -76 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/common-node-cache.h View 1 chunk +24 lines, -18 lines 0 comments Download
A src/compiler/common-node-cache.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/compiler/node-cache.h View 3 chunks +23 lines, -7 lines 0 comments Download
M src/compiler/node-cache.cc View 2 chunks +15 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-node-cache.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
PTAL
6 years ago (2014-12-23 12:57:18 UTC) #2
Igor Sheludko
lgtm
6 years ago (2014-12-23 13:44:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/822923002/1
6 years ago (2014-12-23 13:45:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-23 14:12:12 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-23 14:12:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f9193e047d50b1ffbca95e8185576af82c722b3
Cr-Commit-Position: refs/heads/master@{#25937}

Powered by Google App Engine
This is Rietveld 408576698