Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 822883002: [bindings] Interface functions installConditionallyEnabled[Methods/Properties] should use Local<> (Closed)

Created:
5 years, 12 months ago by vivekg_samsung
Modified:
5 years, 12 months ago
Reviewers:
haraken, vivekg, Jens Widell
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Interface functions installConditionallyEnabled[Methods/Properties] should use Local<> R=haraken@chromium.org BUG=424445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187643

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -79 lines) Patch
M Source/bindings/core/v8/WrapperTypeInfo.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/templates/interface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/methods.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/partial_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8ArrayBuffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8ArrayBufferView.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8DataView.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8SVGTestInterface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestException.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface2.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface3.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor2.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor3.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor4.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceDocument.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEmpty.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventTarget.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNode.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestNode.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestSpecialOperations.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestTypedefs.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8Uint8ClampedArray.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterfacePartial.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
vivekg
PTAL.
5 years, 12 months ago (2014-12-23 05:44:09 UTC) #2
Jens Widell
LGTM
5 years, 12 months ago (2014-12-23 09:21:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/822883002/1
5 years, 12 months ago (2014-12-23 10:24:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=187643
5 years, 12 months ago (2014-12-23 11:50:58 UTC) #7
haraken
5 years, 12 months ago (2014-12-23 14:45:51 UTC) #8
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698