Source/bindings/tests/results/core/V8TestInterface.h - Issue 822883002: [bindings] Interface functions installConditionallyEnabled[Methods/Properties] should use Local<>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterface.h

Issue 822883002: [bindings] Interface functions installConditionallyEnabled[Methods/Properties] should use Local<> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestException.h ('k') | Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterface.h

diff --git a/Source/bindings/tests/results/core/V8TestInterface.h b/Source/bindings/tests/results/core/V8TestInterface.h

index 2370cd727cb4811abbe5318cd8d42ee67664583f..0c84b70552334f6edf63edf1364f876a9a18ca0e 100644

--- a/Source/bindings/tests/results/core/V8TestInterface.h

+++ b/Source/bindings/tests/results/core/V8TestInterface.h

@@ -47,8 +47,8 @@ public:

static void implementsCustomVoidMethodMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&);

static void legacyCallCustom(const v8::FunctionCallbackInfo<v8::Value>&);

static const int internalFieldCount = v8DefaultWrapperInternalFieldCount + 0;

- static void installConditionallyEnabledProperties(v8::Handle<v8::Object>, v8::Isolate*);

- static void installConditionallyEnabledMethods(v8::Handle<v8::Object>, v8::Isolate*);

+ static void installConditionallyEnabledProperties(v8::Local<v8::Object>, v8::Isolate*);

+ static void installConditionallyEnabledMethods(v8::Local<v8::Object>, v8::Isolate*);

static void updateWrapperTypeInfo(InstallTemplateFunction, InstallConditionallyEnabledMethodsFunction);

static void installV8TestInterfaceTemplate(v8::Handle<v8::FunctionTemplate>, v8::Isolate*);

static void registerVoidMethodPartialOverloadMethodForPartialInterface(void (*)(const v8::FunctionCallbackInfo<v8::Value>&));

« no previous file with comments | « Source/bindings/tests/results/core/V8TestException.h ('k') | Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »