Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Side by Side Diff: Source/bindings/templates/interface.cpp

Issue 822883002: [bindings] Interface functions installConditionallyEnabled[Methods/Properties] should use Local<> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/templates/interface.h ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 {% extends 'interface_base.cpp' %} 1 {% extends 'interface_base.cpp' %}
2 2
3 3
4 {##############################################################################} 4 {##############################################################################}
5 {% block indexed_property_getter %} 5 {% block indexed_property_getter %}
6 {% if indexed_property_getter and not indexed_property_getter.is_custom %} 6 {% if indexed_property_getter and not indexed_property_getter.is_custom %}
7 {% set getter = indexed_property_getter %} 7 {% set getter = indexed_property_getter %}
8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info) 8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info)
9 { 9 {
10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder()); 10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder());
(...skipping 849 matching lines...) Expand 10 before | Expand all | Expand 10 after
860 return hasInstance(value, isolate) ? toImpl(v8::Handle<v8::Object>::Cast(val ue)) : 0; 860 return hasInstance(value, isolate) ? toImpl(v8::Handle<v8::Object>::Cast(val ue)) : 0;
861 } 861 }
862 862
863 {% endblock %} 863 {% endblock %}
864 864
865 865
866 {##############################################################################} 866 {##############################################################################}
867 {% block install_conditional_attributes %} 867 {% block install_conditional_attributes %}
868 {% from 'attributes.cpp' import attribute_configuration with context %} 868 {% from 'attributes.cpp' import attribute_configuration with context %}
869 {% if has_conditional_attributes %} 869 {% if has_conditional_attributes %}
870 void {{v8_class}}::installConditionallyEnabledProperties(v8::Handle<v8::Object> instanceObject, v8::Isolate* isolate) 870 void {{v8_class}}::installConditionallyEnabledProperties(v8::Local<v8::Object> i nstanceObject, v8::Isolate* isolate)
871 { 871 {
872 v8::Local<v8::Object> prototypeObject = v8::Local<v8::Object>::Cast(instance Object->GetPrototype()); 872 v8::Local<v8::Object> prototypeObject = v8::Local<v8::Object>::Cast(instance Object->GetPrototype());
873 ExecutionContext* context = toExecutionContext(prototypeObject->CreationCont ext()); 873 ExecutionContext* context = toExecutionContext(prototypeObject->CreationCont ext());
874 874
875 {% for attribute in attributes if attribute.per_context_enabled_function or attribute.exposed_test %} 875 {% for attribute in attributes if attribute.per_context_enabled_function or attribute.exposed_test %}
876 {% filter per_context_enabled(attribute.per_context_enabled_function) %} 876 {% filter per_context_enabled(attribute.per_context_enabled_function) %}
877 {% filter exposed(attribute.exposed_test) %} 877 {% filter exposed(attribute.exposed_test) %}
878 static const V8DOMConfiguration::AttributeConfiguration attributeConfigurati on =\ 878 static const V8DOMConfiguration::AttributeConfiguration attributeConfigurati on =\
879 {{attribute_configuration(attribute)}}; 879 {{attribute_configuration(attribute)}};
880 V8DOMConfiguration::installAttribute(instanceObject, prototypeObject, attrib uteConfiguration, isolate); 880 V8DOMConfiguration::installAttribute(instanceObject, prototypeObject, attrib uteConfiguration, isolate);
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
970 } 970 }
971 971
972 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %} 972 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %}
973 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&)) 973 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&))
974 { 974 {
975 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method; 975 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method;
976 } 976 }
977 {% endfor %} 977 {% endfor %}
978 {% endif %} 978 {% endif %}
979 {% endblock %} 979 {% endblock %}
OLDNEW
« no previous file with comments | « Source/bindings/templates/interface.h ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698