Source/bindings/tests/results/modules/V8TestInterface5.cpp - Issue 822883002: [bindings] Interface functions installConditionallyEnabled[Methods/Properties] should use Local<>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/modules/V8TestInterface5.cpp

Issue 822883002: [bindings] Interface functions installConditionallyEnabled[Methods/Properties] should use Local<> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/modules/V8TestInterface5.h ('k') | Source/bindings/tests/results/modules/V8TestInterfacePartial.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/modules/V8TestInterface5.cpp

diff --git a/Source/bindings/tests/results/modules/V8TestInterface5.cpp b/Source/bindings/tests/results/modules/V8TestInterface5.cpp

index 2bca16c5cdf36c817b17434c4005543398750c54..352d783b72e4febcf46d135ba69091b584dfab6d 100644

--- a/Source/bindings/tests/results/modules/V8TestInterface5.cpp

+++ b/Source/bindings/tests/results/modules/V8TestInterface5.cpp

@@ -883,7 +883,7 @@ TestInterface5Implementation* V8TestInterface5::toImplWithTypeCheck(v8::Isolate*

return hasInstance(value, isolate) ? toImpl(v8::Handle<v8::Object>::Cast(value)) : 0;

}

-void V8TestInterface5::installConditionallyEnabledProperties(v8::Handle<v8::Object> instanceObject, v8::Isolate* isolate)

+void V8TestInterface5::installConditionallyEnabledProperties(v8::Local<v8::Object> instanceObject, v8::Isolate* isolate)

{

v8::Local<v8::Object> prototypeObject = v8::Local<v8::Object>::Cast(instanceObject->GetPrototype());

ExecutionContext* context = toExecutionContext(prototypeObject->CreationContext());

@@ -900,7 +900,7 @@ void V8TestInterface5::installConditionallyEnabledProperties(v8::Handle<v8::Obje

}

-void V8TestInterface5::installConditionallyEnabledMethods(v8::Handle<v8::Object> prototypeObject, v8::Isolate* isolate)

+void V8TestInterface5::installConditionallyEnabledMethods(v8::Local<v8::Object> prototypeObject, v8::Isolate* isolate)

{

v8::Local<v8::Signature> defaultSignature = v8::Signature::New(isolate, domTemplate(isolate));

ExecutionContext* context = toExecutionContext(prototypeObject->CreationContext());