bindings: Fixes layouttests when moving attributes to prototype chains.

bindings: Fixes layouttests when moving attributes to prototype chains.

Fixes layouttests so that they pass when DOM attributes are moved to
prototype chains.

Major changes are:
- JSON.stringify doesn't work for DOM attributes on prototype chains.
  We're going to use stringifyDOMObject instead defined in js-test.js.
- Use of assert_own_property for DOM attributes is wrong.  We use
  assert_will_be_idl_attribute in this CL, and after we move to
  prototype chains, we'll replace it with assert_idl_attribute.
- element-instance-property-listing is expected to list all the DOM
  attributes.  So I changed it to list up all attributes including
  those on prototype.

BUG=43394
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188873

[Yuki, 2015-01-20 13:25:07]

yukishiino@chromium.org changed reviewers:
+ haraken@chromium.org

[Yuki, 2015-01-20 13:25:08]

Could you review this CL?
We have a few more tests to fix in order to apply http://crrev.com/447523003 .

[jsbell, 2015-01-20 17:06:43]

jsbell@chromium.org changed reviewers:
+ jsbell@chromium.org

[jsbell, 2015-01-20 17:06:43]

https://codereview.chromium.org/821303006/diff/40001/LayoutTests/storage/inde...
File LayoutTests/storage/indexeddb/resources/keypath-intrinsic-properties.js
(right):

https://codereview.chromium.org/821303006/diff/40001/LayoutTests/storage/inde...
LayoutTests/storage/indexeddb/resources/keypath-intrinsic-properties.js:33:
blob: JSON.parse(stringifyDOMObject(
Doesn't this change the test? Instead of datum.blob being a Blob instance it
will be a normal JS object.

[Yuki, 2015-01-21 05:44:20]

Patchset #5 (id:80001) has been deleted

[Yuki, 2015-01-21 07:43:24]

https://codereview.chromium.org/821303006/diff/40001/LayoutTests/storage/inde...
File LayoutTests/storage/indexeddb/resources/keypath-intrinsic-properties.js
(right):

https://codereview.chromium.org/821303006/diff/40001/LayoutTests/storage/inde...
LayoutTests/storage/indexeddb/resources/keypath-intrinsic-properties.js:33:
blob: JSON.parse(stringifyDOMObject(
On 2015/01/20 17:06:43, jsbell wrote:
> Doesn't this change the test? Instead of datum.blob being a Blob instance it
> will be a normal JS object.

Ah, good catch!  I should have been more careful.
I updated stringifyDOMObject so that it stringify more complicated object (mixed
of Object / DOMObject and Array).

[jsbell, 2015-01-21 18:09:40]

https://codereview.chromium.org/821303006/diff/120001/LayoutTests/fast/dom/sc...
File LayoutTests/fast/dom/script-tests/webtiming-document-open.js (right):

https://codereview.chromium.org/821303006/diff/120001/LayoutTests/fast/dom/sc...
LayoutTests/fast/dom/script-tests/webtiming-document-open.js:30: var properties
= [];
This pattern repeats often. Perhaps we should add to js-test.js:

function getAllPropertyNames(o) {
  var ps = [];
  for (var p in o)
    ps.push(p);
  ps.sort();
  return ps;
}

https://codereview.chromium.org/821303006/diff/120001/LayoutTests/http/tests/...
File LayoutTests/http/tests/resources/testharness.js (right):

https://codereview.chromium.org/821303006/diff/120001/LayoutTests/http/tests/...
LayoutTests/http/tests/resources/testharness.js:393: *
assert_will_be_idl_attribute(object, attribute_name, description)
I know it's temporary, but we should avoid making local (Blink) additions to
wpt's testharness.js, since it complicates updates. If you do want to make
additions, you'll need an l*g*t*m from dpranke.

Since the tests will need to be modified again after the conversion, how about
adding this new assertion to testharness-helpers.js and including that in the
tests?

https://codereview.chromium.org/821303006/diff/120001/LayoutTests/resources/j...
File LayoutTests/resources/js-test.js (right):

https://codereview.chromium.org/821303006/diff/120001/LayoutTests/resources/j...
LayoutTests/resources/js-test.js:210: var dst = src instanceof Array ? [] : {};
Nit: Use Array.isArray()

(instanceof doesn't work across 'realms')

[Yuki, 2015-01-22 06:53:29]

https://codereview.chromium.org/821303006/diff/120001/LayoutTests/fast/dom/sc...
File LayoutTests/fast/dom/script-tests/webtiming-document-open.js (right):

https://codereview.chromium.org/821303006/diff/120001/LayoutTests/fast/dom/sc...
LayoutTests/fast/dom/script-tests/webtiming-document-open.js:30: var properties
= [];
On 2015/01/21 18:09:39, jsbell wrote:
> This pattern repeats often. Perhaps we should add to js-test.js:
> 
> function getAllPropertyNames(o) {
>   var ps = [];
>   for (var p in o)
>     ps.push(p);
>   ps.sort();
>   return ps;
> }

Done.

https://codereview.chromium.org/821303006/diff/120001/LayoutTests/http/tests/...
File LayoutTests/http/tests/resources/testharness.js (right):

https://codereview.chromium.org/821303006/diff/120001/LayoutTests/http/tests/...
LayoutTests/http/tests/resources/testharness.js:393: *
assert_will_be_idl_attribute(object, attribute_name, description)
On 2015/01/21 18:09:39, jsbell wrote:
> I know it's temporary, but we should avoid making local (Blink) additions to
> wpt's testharness.js, since it complicates updates. If you do want to make
> additions, you'll need an l*g*t*m from dpranke.
> 
> Since the tests will need to be modified again after the conversion, how about
> adding this new assertion to testharness-helpers.js and including that in the
> tests?

Done.

https://codereview.chromium.org/821303006/diff/120001/LayoutTests/resources/j...
File LayoutTests/resources/js-test.js (right):

https://codereview.chromium.org/821303006/diff/120001/LayoutTests/resources/j...
LayoutTests/resources/js-test.js:210: var dst = src instanceof Array ? [] : {};
On 2015/01/21 18:09:39, jsbell wrote:
> Nit: Use Array.isArray()
> 
> (instanceof doesn't work across 'realms')

Done.

[jsbell, 2015-01-22 17:57:30]

lgtm except for the http/tests/w3c change - not sure which tests include that
script but aren't also in that directory?

worker.js is imported from
https://dvcs.w3.org/hg/webperf/file/ad86e8b8d78d/tests/resources/worker.js so
it's also a script we should not modify locally.

(Sorry, didn't notice this one before!)

https://codereview.chromium.org/821303006/diff/140001/LayoutTests/http/tests/...
File LayoutTests/http/tests/w3c/webperf/resources/worker.js (right):

https://codereview.chromium.org/821303006/diff/140001/LayoutTests/http/tests/...
LayoutTests/http/tests/w3c/webperf/resources/worker.js:31: function
stringifyDOMObject(domObject) {
Hrm, I just noticed LayoutTests/http/tests/w3c/README - I guess this should go
elsewhere?

[haraken, 2015-01-23 01:41:32]

LGTM

https://codereview.chromium.org/821303006/diff/140001/LayoutTests/fast/svg/SV...
File LayoutTests/fast/svg/SVGStyleElement.html (right):

https://codereview.chromium.org/821303006/diff/140001/LayoutTests/fast/svg/SV...
LayoutTests/fast/svg/SVGStyleElement.html:17: // assert_idl_attribute(style,
"sheet", description);

Can we use assert_will_be_idl_attribute?

https://codereview.chromium.org/821303006/diff/140001/LayoutTests/http/tests/...
File LayoutTests/http/tests/resources/testharness-helpers.js (right):

https://codereview.chromium.org/821303006/diff/140001/LayoutTests/http/tests/...
LayoutTests/http/tests/resources/testharness-helpers.js:143: // chain.

Add a crbug number.

[Yuki, 2015-01-23 08:06:20]

https://codereview.chromium.org/821303006/diff/140001/LayoutTests/fast/svg/SV...
File LayoutTests/fast/svg/SVGStyleElement.html (right):

https://codereview.chromium.org/821303006/diff/140001/LayoutTests/fast/svg/SV...
LayoutTests/fast/svg/SVGStyleElement.html:17: // assert_idl_attribute(style,
"sheet", description);
On 2015/01/23 01:41:32, haraken wrote:
> 
> Can we use assert_will_be_idl_attribute?

This is not a test in http/tets/, and I think we shouldn't use
http/tests/resources/testharness-helpers.js where I added
assert_will_be_idl_attribute.

Unlike http/tests/, we don't have LayoutTests/resources/testharness-helpers.js,
so there seems no good place to add assert_will_be_idl_attribute.  And this is
the only test which wants assert_will_be_idl_attribute.  Maybe not worth adding
LayoutTests/resources/testharness-helpers.js.

https://codereview.chromium.org/821303006/diff/140001/LayoutTests/http/tests/...
File LayoutTests/http/tests/resources/testharness-helpers.js (right):

https://codereview.chromium.org/821303006/diff/140001/LayoutTests/http/tests/...
LayoutTests/http/tests/resources/testharness-helpers.js:143: // chain.
On 2015/01/23 01:41:32, haraken wrote:
> 
> Add a crbug number.

Done.

https://codereview.chromium.org/821303006/diff/140001/LayoutTests/http/tests/...
File LayoutTests/http/tests/w3c/webperf/resources/worker.js (right):

https://codereview.chromium.org/821303006/diff/140001/LayoutTests/http/tests/...
LayoutTests/http/tests/w3c/webperf/resources/worker.js:31: function
stringifyDOMObject(domObject) {
On 2015/01/22 17:57:29, jsbell wrote:
> Hrm, I just noticed LayoutTests/http/tests/w3c/README - I guess this should go
> elsewhere?

Reverted this file and fixed
performance-memory-in-{dedicated,shared}-worker.html tests so that they don't
use stringifyDOMObject.

[Yuki, 2015-01-23 11:07:53]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2015-01-23 11:08:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/821303006/180001

[commit-bot: I haz the power, 2015-01-23 11:12:29]

Committed patchset #9 (id:180001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188873