LayoutTests/http/tests/push_messaging/subscribe_success.html - Issue 821303006: bindings: Fixes layouttests when moving attributes to prototype chains.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/push_messaging/subscribe_success.html

Issue 821303006: bindings: Fixes layouttests when moving attributes to prototype chains. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed performance memory tests and addressed review comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/http/tests/push_messaging/subscribe_success.html

diff --git a/LayoutTests/http/tests/push_messaging/subscribe_success.html b/LayoutTests/http/tests/push_messaging/subscribe_success.html

index 196e6c4803369a3ba095fc47d46425643954b945..08eb626a85400f3d856942cfe21114844493906e 100644

--- a/LayoutTests/http/tests/push_messaging/subscribe_success.html

+++ b/LayoutTests/http/tests/push_messaging/subscribe_success.html

@@ -5,6 +5,7 @@

+<script src="../resources/testharness-helpers.js"></script>

</head>

<body>

@@ -25,10 +26,10 @@ async_test(function(test) {

return swRegistration.pushManager.subscribe();

})

.then(function(pushSubscription) {

- assert_own_property(pushSubscription, 'subscriptionId');

+ assert_will_be_idl_attribute(pushSubscription, 'subscriptionId');

assert_equals(typeof pushSubscription.subscriptionId, 'string');

- assert_own_property(pushSubscription, 'endpoint');

+ assert_will_be_idl_attribute(pushSubscription, 'endpoint');

assert_equals(typeof pushSubscription.endpoint, 'string');

try {

var endpointUrl = new URL(pushSubscription.endpoint);