LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js - Issue 821303006: bindings: Fixes layouttests when moving attributes to prototype chains.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

Issue 821303006: bindings: Fixes layouttests when moving attributes to prototype chains. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed performance memory tests and addressed review comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/misc/performance-memory-in-shared-worker.html ('k') | LayoutTests/http/tests/notifications/serviceworker-notification-event.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

diff --git a/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js b/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

index fd545ea85582bcb349f95824cea07fa94c0cd0a5..94ffdf36c06017e7653560149d9fc9a32b338d3b 100644

--- a/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

+++ b/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

@@ -6,7 +6,7 @@ test(function() {

var event = new NotificationEvent('NotificationEvent');

assert_equals(event.type, 'NotificationEvent');

- assert_own_property(event, 'notification');

+ assert_will_be_idl_attribute(event, 'notification');

assert_equals(event.cancelable, false);

assert_equals(event.bubbles, false);

assert_equals(event.notification, null);

@@ -25,7 +25,9 @@ test(function() {

}, 'NotificationEvent is exposed, and has the expected interface.');

test(function() {

- assert_own_property(self, 'onnotificationclick', 'The notificationclick event exists.');

- assert_own_property(self, 'onnotificationerror', 'The notificationerror event exists.');

+ assert_will_be_idl_attribute(self, 'onnotificationclick',

+ 'The notificationclick event exists.');

+ assert_will_be_idl_attribute(self, 'onnotificationerror',

+ 'The notificationerror event exists.');

}, 'The notificationclick and notificationerror events exist on the global scope.');