LayoutTests/fast/svg/SVGStyleElement.html - Issue 821303006: bindings: Fixes layouttests when moving attributes to prototype chains.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/svg/SVGStyleElement.html

Issue 821303006: bindings: Fixes layouttests when moving attributes to prototype chains. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed review comments. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fast/mediastream/RTCSessionDescription-expected.txt ('k') | LayoutTests/http/tests/misc/performance-memory-in-dedicated-worker.html » ('j') | LayoutTests/http/tests/resources/testharness-helpers.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <title>SVGStyleElement tests</title>	2 <title>SVGStyleElement tests</title>

3 <script src=../../resources/testharness.js></script>	3 <script src=../../resources/testharness.js></script>

4 <script src=../../resources/testharnessreport.js></script>	4 <script src=../../resources/testharnessreport.js></script>

5 <div id="testcontainer">	5 <div id="testcontainer">

6 <svg width="1" height="1" visibility="hidden">	6 <svg width="1" height="1" visibility="hidden">

7 <defs><style>.test { fill: green; }</style></defs>	7 <defs><style>.test { fill: green; }</style></defs>

8 </svg>	8 </svg>

9 </div>	9 </div>

10 <div id=log></div>	10 <div id=log></div>

11 <script>	11 <script>

12 var svg = document.querySelector("svg"),	12 var svg = document.querySelector("svg"),

13 » style = document.querySelector("style");	13 style = document.querySelector("style");

14	14

15 test(function() {	15 test(function() {

16 » assert_exists(style, "sheet", "");	16 // FIXME: This assertion should be replaced with

	17 // assert_idl_attribute(style, "sheet", description);
	haraken 2015/01/23 01:41:32 Can we use assert_will_be_idl_attribute? Can we use assert_will_be_idl_attribute? Yuki 2015/01/23 08:06:20 This is not a test in http/tets/, and I think we s Show quoted text On 2015/01/23 01:41:32, haraken wrote: > > Can we use assert_will_be_idl_attribute? This is not a test in http/tets/, and I think we shouldn't use http/tests/resources/testharness-helpers.js where I added assert_will_be_idl_attribute. Unlike http/tests/, we don't have LayoutTests/resources/testharness-helpers.js, so there seems no good place to add assert_will_be_idl_attribute. And this is the only test which wants assert_will_be_idl_attribute. Maybe not worth adding LayoutTests/resources/testharness-helpers.js.
	18 assert_true("sheet" in style, "");

17 }, "SVGStyleElement implements LinkStyle");	19 }, "SVGStyleElement implements LinkStyle");

18	20

19 test(function() {	21 test(function() {

20 » assert_equals(document.styleSheets[0], style.sheet);	22 assert_equals(document.styleSheets[0], style.sheet);

21 }, "document.styleSheets contains style.sheet");	23 }, "document.styleSheets contains style.sheet");

22	24

23 test(function() {	25 test(function() {

24 » assert_equals(document.styleSheets[0].ownerNode, style);	26 assert_equals(document.styleSheets[0].ownerNode, style);

25 }, "sheet has correct ownerNode #1");	27 }, "sheet has correct ownerNode #1");

26	28

27 test(function() {	29 test(function() {

28 » assert_equals(style.sheet.ownerNode, style);	30 assert_equals(style.sheet.ownerNode, style);

29 }, "sheet has correct ownerNode #2");	31 }, "sheet has correct ownerNode #2");

30	32

31 </script>	33 </script>

OLD	NEW