Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 819853002: [bindings] Translate all assignments in bindings/templates to use Local<> in place of Handle<>. (Closed)

Created:
6 years ago by vivekg_samsung
Modified:
6 years ago
Reviewers:
haraken, vivekg
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Translate all assignments in bindings/templates to use Local<> in place of Handle<>. BUG=424445 R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187606

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+618 lines, -618 lines) Patch
M Source/bindings/templates/attributes.cpp View 7 chunks +10 lines, -10 lines 0 comments Download
M Source/bindings/templates/callback_interface.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/templates/interface_base.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/methods.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
M Source/bindings/tests/results/core/V8DataView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8SVGTestInterface.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestCallbackInterface.cpp View 10 chunks +20 lines, -20 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestException.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 49 chunks +53 lines, -53 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface2.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 18 chunks +28 lines, -28 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp View 13 chunks +16 lines, -16 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 11 chunks +11 lines, -11 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestNode.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 338 chunks +384 lines, -384 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestSpecialOperations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestTypedefs.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/core/V8Uint8ClampedArray.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 18 chunks +18 lines, -18 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
vivekg
Trivial one. PTAL, thanks!
6 years ago (2014-12-22 07:14:41 UTC) #2
haraken
LGTM
6 years ago (2014-12-22 07:18:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819853002/1
6 years ago (2014-12-22 08:26:26 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-22 08:30:25 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187606

Powered by Google App Engine
This is Rietveld 408576698