Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: Source/bindings/templates/callback_interface.cpp

Issue 819853002: [bindings] Translate all assignments in bindings/templates to use Local<> in place of Handle<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/templates/interface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/callback_interface.cpp
diff --git a/Source/bindings/templates/callback_interface.cpp b/Source/bindings/templates/callback_interface.cpp
index a990e3ac39d1c5a52e42ad355df927c87f401d53..a36e6c1f4f7d39d19cd5a46473fdd30f4af27bf2 100644
--- a/Source/bindings/templates/callback_interface.cpp
+++ b/Source/bindings/templates/callback_interface.cpp
@@ -38,7 +38,7 @@ namespace blink {
ScriptState::Scope scope(m_scriptState.get());
{% if method.call_with_this_handle %}
- v8::Handle<v8::Value> thisHandle = thisValue.v8Value();
+ v8::Local<v8::Value> thisHandle = thisValue.v8Value();
if (thisHandle.IsEmpty()) {
if (!isScriptControllerTerminating())
CRASH();
@@ -46,7 +46,7 @@ namespace blink {
}
{% endif %}
{% for argument in method.arguments %}
- v8::Handle<v8::Value> {{argument.handle}} = {{argument.cpp_value_to_v8_value}};
+ v8::Local<v8::Value> {{argument.handle}} = {{argument.cpp_value_to_v8_value}};
if ({{argument.handle}}.IsEmpty()) {
if (!isScriptControllerTerminating())
CRASH();
@@ -54,10 +54,10 @@ namespace blink {
}
{% endfor %}
{% if method.arguments %}
- v8::Handle<v8::Value> argv[] = { {{method.arguments | join(', ', 'handle')}} };
+ v8::Local<v8::Value> argv[] = { {{method.arguments | join(', ', 'handle')}} };
{% else %}
{# Empty array initializers are illegal, and don't compile in MSVC. #}
- v8::Handle<v8::Value> *argv = 0;
+ v8::Local<v8::Value> *argv = 0;
{% endif %}
{% set this_handle_parameter = 'thisHandle, ' if method.call_with_this_handle else 'm_scriptState->context()->Global(), ' %}
« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | Source/bindings/templates/interface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698