Source/bindings/templates/interface_base.cpp - Issue 819853002: [bindings] Translate all assignments in bindings/templates to use Local<> in place of Handle<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/interface_base.cpp

Issue 819853002: [bindings] Translate all assignments in bindings/templates to use Local<> in place of Handle<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/templates/interface_base.cpp

diff --git a/Source/bindings/templates/interface_base.cpp b/Source/bindings/templates/interface_base.cpp

index 231545797c6fbdae7e1e83524987eaf3e456c8ab..9a74d116ab810f1f44dce275e1bfa937d09cecf1 100644

--- a/Source/bindings/templates/interface_base.cpp

+++ b/Source/bindings/templates/interface_base.cpp

@@ -78,7 +78,7 @@ static void (*{{method.name}}MethodForPartialInterface)(const v8::FunctionCallba

{% if has_constructor_attributes %}

static void {{cpp_class}}ConstructorGetter(v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info)

{

- v8::Handle<v8::Value> data = info.Data();

+ v8::Local<v8::Value> data = info.Data();

ASSERT(data->IsExternal());

V8PerContextData* perContextData = V8PerContextData::from(info.Holder()->CreationContext());

if (!perContextData)

« no previous file with comments | « Source/bindings/templates/interface.cpp ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »