Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp - Issue 819853002: [bindings] Translate all assignments in bindings/templates to use Local<> in place of Handle<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp

Issue 819853002: [bindings] Translate all assignments in bindings/templates to use Local<> in place of Handle<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp b/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp

index c76cdbfb7661a0d9b7cac37deb9516fadfce482d..680d1c341064b65103856753fdff3c25cd22109e 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp

@@ -33,7 +33,7 @@ namespace TestInterfaceGarbageCollectedV8Internal {

static void attr1AttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)

{

- v8::Handle<v8::Object> holder = info.Holder();

+ v8::Local<v8::Object> holder = info.Holder();

TestInterfaceGarbageCollected* impl = V8TestInterfaceGarbageCollected::toImpl(holder);

v8SetReturnValueFast(info, WTF::getPtr(impl->attr1()), impl);

}

@@ -47,7 +47,7 @@ static void attr1AttributeGetterCallback(v8::Local<v8::String>, const v8::Proper

static void attr1AttributeSetter(v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info)

{

- v8::Handle<v8::Object> holder = info.Holder();

+ v8::Local<v8::Object> holder = info.Holder();

TestInterfaceGarbageCollected* impl = V8TestInterfaceGarbageCollected::toImpl(holder);

TestInterfaceGarbageCollected* cppValue = V8TestInterfaceGarbageCollected::toImplWithTypeCheck(info.GetIsolate(), v8Value);

impl->setAttr1(WTF::getPtr(cppValue));

@@ -92,7 +92,7 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)

TOSTRING_VOID_INTERNAL(str, info[0]);

}

RawPtr<TestInterfaceGarbageCollected> impl = TestInterfaceGarbageCollected::create(str);

- v8::Handle<v8::Object> wrapper = info.Holder();

+ v8::Local<v8::Object> wrapper = info.Holder();

impl->associateWithWrapper(info.GetIsolate(), &V8TestInterfaceGarbageCollected::wrapperTypeInfo, wrapper);

v8SetReturnValue(info, wrapper);

}