Issue 818583002: Moves Create() off of View and onto ViewManager

Issue 818583002: Moves Create() off of View and onto ViewManager (Closed)

Created:
6 years ago by sky

Modified:
6 years ago

Reviewers:
Ben Goodger (Google)

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Moves Create() off of View and onto ViewManager This makes more sense given the ViewManager is used to create the view. R=ben@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/50c08a389bc187a59e5596f2622eb8ed0ad0152d

Patch Set 1 #

Patch Set 2 : format #

Patch Set 3 : merge 2 trunk #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -63 lines)			Patch
M	examples/media_viewer/media_viewer.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	examples/nesting_app/nesting_app.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	examples/recipes/window_manager/window_manager.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	examples/window_manager/window_manager.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	examples/wm_flow/app/app.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	examples/wm_flow/wm/frame_controller.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	examples/wm_flow/wm/wm.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/services/view_manager/public/cpp/lib/view.cc	View		5 chunks	+6 lines, -13 lines	0 comments	Download
M	mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc	View	1	4 chunks	+15 lines, -9 lines	0 comments	Download
M	mojo/services/view_manager/public/cpp/lib/view_private.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/services/view_manager/public/cpp/tests/view_manager_unittest.cc	View		13 chunks	+18 lines, -18 lines	0 comments	Download
M	mojo/services/view_manager/public/cpp/view.h	View		2 chunks	+1 line, -5 lines	0 comments	Download
M	mojo/services/view_manager/public/cpp/view_manager.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	services/window_manager/main.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/tools/debugger/debugger.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/tools/tester/tester.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/viewer/document_view.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

6 years ago (2014-12-19 15:45:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
50c08a389bc187a59e5596f2622eb8ed0ad0152d (presubmit successful).

Expand Messages | Collapse Messages