services/window_manager/main.cc - Issue 818583002: Moves Create() off of View and onto ViewManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/window_manager/main.cc

Issue 818583002: Moves Create() off of View and onto ViewManager (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: merge 2 trunk Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/window_manager/main.cc

diff --git a/services/window_manager/main.cc b/services/window_manager/main.cc

index 1d069e0abf7167c15f887baefc6d80795d50d380..43f0e34acd1c063c70621abf5e42f679da7f1db8 100644

--- a/services/window_manager/main.cc

+++ b/services/window_manager/main.cc

@@ -54,7 +54,7 @@ class DefaultWindowManager : public mojo::ApplicationDelegate,

void Embed(

const mojo::String& url,

mojo::InterfaceRequest<mojo::ServiceProvider> service_provider) override {

- View* view = View::Create(root_->view_manager());

+ View* view = root_->view_manager()->CreateView();

root_->AddChild(view);

view->SetVisible(true);

view->Embed(url, scoped_ptr<mojo::ServiceProviderImpl>(

« no previous file with comments | « mojo/services/view_manager/public/cpp/view_manager.h ('k') | sky/tools/debugger/debugger.cc » ('j') | no next file with comments »