Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1187)

Unified Diff: mojo/services/view_manager/public/cpp/view.h

Issue 818583002: Moves Create() off of View and onto ViewManager (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: merge 2 trunk Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/view_manager/public/cpp/view.h
diff --git a/mojo/services/view_manager/public/cpp/view.h b/mojo/services/view_manager/public/cpp/view.h
index 89fc973b2e3f9c331981f050ee6cf1ec487a6ff5..3222b330f08bd5dc2de26a09ee5210596ebc68bd 100644
--- a/mojo/services/view_manager/public/cpp/view.h
+++ b/mojo/services/view_manager/public/cpp/view.h
@@ -36,10 +36,6 @@ class View {
using Children = std::vector<View*>;
using SharedProperties = std::map<std::string, std::vector<uint8_t>>;
- // Creates and returns a new View (which is owned by the ViewManager). Views
- // are initially hidden, use SetVisible(true) to show.
- static View* Create(ViewManager* view_manager);
-
// Destroys this view and all its children.
void Destroy();
@@ -138,7 +134,7 @@ class View {
friend class ViewPrivate;
friend class ViewManagerClientImpl;
- explicit View(ViewManager* manager);
+ View(ViewManager* manager, Id id);
// Called by the public {Set,Get,Clear}Property functions.
int64 SetLocalPropertyInternal(const void* key,

Powered by Google App Engine
This is Rietveld 408576698