mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h - Issue 818583002: Moves Create() off of View and onto ViewManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h

Issue 818583002: Moves Create() off of View and onto ViewManager (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: merge 2 trunk Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/services/view_manager/public/cpp/lib/view.cc ('k') | mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h

diff --git a/mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h b/mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h

index 91e43583240c2d0c679876e02e4390b3ae68fd07..f7bef8bbac2d48414444c62337f4a034dde808f3 100644

--- a/mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h

+++ b/mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h

@@ -39,7 +39,6 @@ class ViewManagerClientImpl : public ViewManager,

// API exposed to the view implementations that pushes local changes to the

// service.

- Id CreateView();

void DestroyView(Id view_id);

// These methods take TransportIds. For views owned by the current connection,

@@ -83,11 +82,14 @@ class ViewManagerClientImpl : public ViewManager,

typedef std::map<Id, View*> IdToViewMap;

+ Id CreateViewOnServer();

// Overridden from ViewManager:

const std::string& GetEmbedderURL() const override;

View* GetRoot() override;

View* GetViewById(Id id) override;

View* GetFocusedView() override;

+ View* CreateView() override;

// Overridden from ViewManagerClient:

void OnEmbed(ConnectionSpecificId connection_id,