Remove localcoordchange functions off paint

This CL cleans up the last remaining users of localCoordChange on paint

NOTREECHECKS=True
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/8fc6c2d82c1f30ff82274334c01f0799def6a609

[joshualitt, 2014-12-19 22:37:16]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com

[joshualitt, 2014-12-19 22:37:41]

joshualitt@google.com changed reviewers:
+ joshualitt@google.com

[joshualitt, 2014-12-22 15:21:51]

Okay, this is ready for review, perspective matrix is now reflected in the key.

[bsalomon, 2014-12-22 15:33:54]

haven't finished looking yet... but mostly looks right

https://codereview.chromium.org/817853002/diff/60001/src/gpu/GrAAConvexPathRe...
File src/gpu/GrAAConvexPathRenderer.cpp (right):

https://codereview.chromium.org/817853002/diff/60001/src/gpu/GrAAConvexPathRe...
src/gpu/GrAAConvexPathRenderer.cpp:578: b->add32((local.fInputColorType << 16) |
The fact that we have to do this all over the place makes me wonder if LM
handling should be a base class activity for now (until d.g. lets subclasses
actually do something with the LM). Thoughts?

https://codereview.chromium.org/817853002/diff/60001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/817853002/diff/60001/src/gpu/GrContext.cpp#ne...
src/gpu/GrContext.cpp:578: GR_CREATE_TRACE_MARKER("GrContext::drawPaint",
target);
this looks duplicated from above? probably don't want two traces.

[bsalomon, 2014-12-22 21:13:55]

https://codereview.chromium.org/817853002/diff/100001/src/gpu/GrDrawTarget.h
File src/gpu/GrDrawTarget.h (right):

https://codereview.chromium.org/817853002/diff/100001/src/gpu/GrDrawTarget.h#...
src/gpu/GrDrawTarget.h:306: * @param localMatrix optional matrix applied to
localRect(if not NULL), or local coords. If
Howabout,

"Optional local matrix. The local coordinates are specified by localRect, or if
it is NULL by rect. This matrix applies to the coordinate implied by that
rectangle before it is input to GrCoordTransforms that read local coordinates."

The existing comment references "srcRect" and "srcMatrix" which were renamed to
"localRect" and "localMatrix".

https://codereview.chromium.org/817853002/diff/100001/src/gpu/GrInOrderDrawBu...
File src/gpu/GrInOrderDrawBuffer.cpp (right):

https://codereview.chromium.org/817853002/diff/100001/src/gpu/GrInOrderDrawBu...
src/gpu/GrInOrderDrawBuffer.cpp:123: SkAutoTUnref<const GrGeometryProcessor>
gp(create_rect_gp(SkToBool(localRect), color,
Seems like here if we have a localRect then we should pass NULL for lm since we
will apply it to the vertex attr below, rather than adding that logic to
create_rect_gp.

https://codereview.chromium.org/817853002/diff/100001/src/gpu/GrOvalRenderer.cpp
File src/gpu/GrOvalRenderer.cpp (right):

https://codereview.chromium.org/817853002/diff/100001/src/gpu/GrOvalRenderer....
src/gpu/GrOvalRenderer.cpp:127: b->add32(local.fUsesLocalCoords &&
processor.localMatrix().hasPerspective());
here and the others below, can't we just use a bit in the first int of the key?
looks like a single bool is given the top 16 bits currently.

https://codereview.chromium.org/817853002/diff/100001/src/gpu/effects/GrBezie...
File src/gpu/effects/GrBezierEffect.cpp (right):

https://codereview.chromium.org/817853002/diff/100001/src/gpu/effects/GrBezie...
src/gpu/effects/GrBezierEffect.cpp:168: key |= local.fUsesLocalCoords &&
processor.localMatrix().hasPerspective() ? 0x16 : 0x0;
0x10? and others below

https://codereview.chromium.org/817853002/diff/100001/src/gpu/effects/GrBitma...
File src/gpu/effects/GrBitmapTextGeoProc.cpp (right):

https://codereview.chromium.org/817853002/diff/100001/src/gpu/effects/GrBitma...
src/gpu/effects/GrBitmapTextGeoProc.cpp:80: key |= local.fUsesLocalCoords &&
proc.localMatrix().hasPerspective() ? 0x4 : 0x0;
0x2?

https://codereview.chromium.org/817853002/diff/100001/src/gpu/effects/GrBitma...
src/gpu/effects/GrBitmapTextGeoProc.cpp:82: b->add32(local.fInputColorType);
Seems like colorInputType would fit in the available 30 bits in the first int.

https://codereview.chromium.org/817853002/diff/100001/src/gpu/effects/GrDista...
File src/gpu/effects/GrDistanceFieldTextureEffect.cpp (right):

https://codereview.chromium.org/817853002/diff/100001/src/gpu/effects/GrDista...
src/gpu/effects/GrDistanceFieldTextureEffect.cpp:170:
b->add32((local.fInputColorType << 16) |
consolidate in a single int?

[joshualitt, 2014-12-22 21:37:02]

feedback incorporated

[bsalomon, 2014-12-22 21:51:14]

lgtm

[joshualitt, 2014-12-22 23:16:46]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2014-12-22 23:17:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/817853002/180001

[joshualitt, 2014-12-22 23:26:02]

The CQ bit was unchecked by joshualitt@google.com

[joshualitt, 2014-12-22 23:26:18]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2014-12-22 23:26:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/817853002/180001

[commit-bot: I haz the power, 2014-12-22 23:27:09]

Committed patchset #10 (id:180001) as
https://skia.googlesource.com/skia/+/8fc6c2d82c1f30ff82274334c01f0799def6a609