Change all uses of the RoundedRect class to use FloatRoundedRect instead.

Change all uses of the RoundedRect class to use FloatRoundedRect instead.

This is step 1 of subpixel positioning of rounded rects. That will in turn allow
us to get rid of most of the bleed-avoidance code in BoxDecorationData. And that
code is not Slimming Paint compatible (see the referenced bug).

The CL also gets rid of duplicate code between the two classes.

BUG=382491
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187752

[chrishtr, 2014-12-22 23:28:16]

chrishtr@chromium.org changed reviewers:
+ trchen@chromium.org

[chrishtr, 2014-12-22 23:28:17]

https://codereview.chromium.org/815933006/diff/40001/LayoutTests/TestExpectat...
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/815933006/diff/40001/LayoutTests/TestExpectat...
LayoutTests/TestExpectations:1: crbug.com/382491
fast/borders/border-radius-constraints.html [ NeedsRebaseline ]
These are all very small subpixel adjustments.

[trchen, 2014-12-22 23:32:59]

LGTM. Looks like it is only clerical change. Is the performance impact for
switching from integer to float negligible?

[chrishtr, 2014-12-23 18:05:14]

On 2014/12/22 at 23:32:59, trchen wrote:
> LGTM. Looks like it is only clerical change.

Correct. The functional change will come later.

> Is the performance impact for switching from integer to float negligible?

I don't think there should be any performance difference. Floating-point
arithmetic is plenty fast these days.

[danakj, 2014-12-23 18:19:48]

On Tue, Dec 23, 2014 at 10:05 AM, <chrishtr@chromium.org> wrote:

> On 2014/12/22 at 23:32:59, trchen wrote:
>
>> LGTM. Looks like it is only clerical change.
>>
>
> Correct. The functional change will come later.
>
>  Is the performance impact for switching from integer to float negligible?
>>
>
> I don't think there should be any performance difference. Floating-point
> arithmetic is plenty fast these days.
>

Just FYI.. Not sure if it applies here, but converting floats to ints is
much more costly than you'd expect. So we should be careful about
introducing conversions between the two.

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chrishtr, 2014-12-24 02:09:36]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-12-24 02:10:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/815933006/140001

[commit-bot: I haz the power, 2014-12-24 04:43:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-24 04:43:21]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/36640)

[chrishtr, 2014-12-24 19:47:46]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-12-24 19:48:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/815933006/140001

[commit-bot: I haz the power, 2014-12-24 22:15:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-24 22:15:41]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/36711)

[chrishtr, 2014-12-24 23:24:29]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-12-24 23:24:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/815933006/160001

[commit-bot: I haz the power, 2014-12-24 23:29:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-24 23:29:35]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/10...)

[chrishtr, 2014-12-25 05:35:18]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-12-25 05:35:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/815933006/160001

[commit-bot: I haz the power, 2014-12-25 05:40:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-25 05:40:51]

Try jobs failed on following builders:
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/43759)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/10...)

[chrishtr, 2014-12-29 18:13:11]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-12-29 18:13:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/815933006/160001

[commit-bot: I haz the power, 2014-12-29 19:01:53]

Committed patchset #9 (id:160001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187752