Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 815643005: Move program descriptor and primitive processor off of optstate (Closed)

Created:
5 years, 11 months ago by joshua.litt
Modified:
5 years, 11 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : dm fix #

Patch Set 3 : cleanup #

Patch Set 4 : bug fix #

Patch Set 5 : cleanup #

Patch Set 6 : small cleanup #

Total comments: 1

Patch Set 7 : feedback inc #

Patch Set 8 : bug fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -218 lines) Patch
M src/gpu/GrGeometryProcessor.h View 1 2 3 4 5 6 1 chunk +0 lines, -7 lines 0 comments Download
M src/gpu/GrGeometryProcessor.cpp View 1 2 3 4 5 6 6 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrGpu.h View 1 2 3 4 5 6 5 chunks +29 lines, -8 lines 0 comments Download
M src/gpu/GrGpu.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 2 3 4 11 chunks +19 lines, -11 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 2 3 4 5 6 6 chunks +38 lines, -23 lines 0 comments Download
M src/gpu/GrOptDrawState.h View 1 2 3 5 chunks +4 lines, -12 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 1 2 3 4 5 6 5 chunks +8 lines, -32 lines 0 comments Download
M src/gpu/GrTest.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 4 chunks +10 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 3 4 5 6 9 chunks +23 lines, -20 lines 0 comments Download
M src/gpu/gl/GrGLGpuProgramCache.cpp View 1 2 3 4 5 6 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 7 chunks +19 lines, -17 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.h View 2 chunks +6 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 2 3 4 5 6 4 chunks +10 lines, -8 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 2 3 4 5 6 10 chunks +27 lines, -27 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 3 4 5 6 7 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
joshualitt
Please take a look
5 years, 11 months ago (2015-01-16 19:24:12 UTC) #3
bsalomon
https://codereview.chromium.org/815643005/diff/100001/src/gpu/GrGpu.h File src/gpu/GrGpu.h (right): https://codereview.chromium.org/815643005/diff/100001/src/gpu/GrGpu.h#newcode364 src/gpu/GrGpu.h:364: struct DrawArgs { Is this going to be a ...
5 years, 11 months ago (2015-01-16 21:00:33 UTC) #4
joshualitt
On 2015/01/16 21:00:33, bsalomon wrote: > https://codereview.chromium.org/815643005/diff/100001/src/gpu/GrGpu.h > File src/gpu/GrGpu.h (right): > > https://codereview.chromium.org/815643005/diff/100001/src/gpu/GrGpu.h#newcode364 > ...
5 years, 11 months ago (2015-01-16 23:18:08 UTC) #5
joshualitt
On 2015/01/16 23:18:08, joshualitt wrote: > On 2015/01/16 21:00:33, bsalomon wrote: > > https://codereview.chromium.org/815643005/diff/100001/src/gpu/GrGpu.h > ...
5 years, 11 months ago (2015-01-20 16:08:47 UTC) #6
bsalomon
lgtm
5 years, 11 months ago (2015-01-20 16:19:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/815643005/140001
5 years, 11 months ago (2015-01-20 17:01:34 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 17:08:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/873ad0e0b4d67bdc7bad025018f597450e7004c6

Powered by Google App Engine
This is Rietveld 408576698