tools/telemetry/telemetry/results/page_run_unittest.py - Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/page_run_unittest.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix linter issues Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/results/json_output_formatter_unittest.py ('k') | tools/telemetry/telemetry/results/page_test_results_unittest.py » ('j') | tools/telemetry/telemetry/value/scalar.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/results/page_run_unittest.py

diff --git a/tools/telemetry/telemetry/results/page_run_unittest.py b/tools/telemetry/telemetry/results/page_run_unittest.py

index 23ce50680672fdaea0828611bcf0e6ed41722679..52b4244b49712edfb3e79b82d99851f026dbb390 100644

--- a/tools/telemetry/telemetry/results/page_run_unittest.py

+++ b/tools/telemetry/telemetry/results/page_run_unittest.py

@@ -9,6 +9,7 @@ from telemetry import page as page_module

from telemetry.page import page_set

from telemetry.results import page_run

from telemetry.value import failure

+from telemetry.value import improvement_direction

from telemetry.value import scalar

from telemetry.value import skip

@@ -31,7 +32,9 @@ class PageRunTest(unittest.TestCase):

self.assertFalse(run.skipped)

run = page_run.PageRun(self.pages[0])

- run.AddValue(scalar.ScalarValue(self.pages[0], 'a', 's', 1))

+ run.AddValue(scalar.ScalarValue(

+ self.pages[0], 'a', 's', 1,

+ improvement_direction=improvement_direction.DOWN))

run.AddValue(failure.FailureValue.FromMessage(self.pages[0], 'test'))

self.assertFalse(run.ok)

self.assertTrue(run.failed)

@@ -46,7 +49,9 @@ class PageRunTest(unittest.TestCase):

self.assertTrue(run.skipped)

run = page_run.PageRun(self.pages[0])

- run.AddValue(scalar.ScalarValue(self.pages[0], 'a', 's', 1))

+ run.AddValue(scalar.ScalarValue(

+ self.pages[0], 'a', 's', 1,

+ improvement_direction=improvement_direction.DOWN))

run.AddValue(skip.SkipValue(self.pages[0], 'test'))

self.assertFalse(run.ok)

self.assertFalse(run.failed)

@@ -59,7 +64,9 @@ class PageRunTest(unittest.TestCase):

self.assertFalse(run.skipped)

run = page_run.PageRun(self.pages[0])

- run.AddValue(scalar.ScalarValue(self.pages[0], 'a', 's', 1))

+ run.AddValue(scalar.ScalarValue(

+ self.pages[0], 'a', 's', 1,

+ improvement_direction=improvement_direction.DOWN))

self.assertTrue(run.ok)

self.assertFalse(run.failed)

self.assertFalse(run.skipped)