Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: tools/telemetry/telemetry/results/json_output_formatter_unittest.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix linter issues Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/json_output_formatter_unittest.py
diff --git a/tools/telemetry/telemetry/results/json_output_formatter_unittest.py b/tools/telemetry/telemetry/results/json_output_formatter_unittest.py
index 5b6bebdd6e160815a0f6074a5dbd464858ad1bad..8d2e7730399d1a68baf4f785294a1e706a378569 100644
--- a/tools/telemetry/telemetry/results/json_output_formatter_unittest.py
+++ b/tools/telemetry/telemetry/results/json_output_formatter_unittest.py
@@ -13,6 +13,7 @@ from telemetry import page as page_module
from telemetry.page import page_set
from telemetry.results import json_output_formatter
from telemetry.results import page_test_results
+from telemetry.value import improvement_direction
from telemetry.value import scalar
from telemetry.value import trace
from telemetry.timeline import trace_data
@@ -44,7 +45,8 @@ class JsonOutputFormatterTest(unittest.TestCase):
self._output.truncate(0)
results.WillRunPage(self._page_set[0])
- v0 = scalar.ScalarValue(results.current_page, 'foo', 'seconds', 3)
+ v0 = scalar.ScalarValue(results.current_page, 'foo', 'seconds', 3,
+ improvement_direction=improvement_direction.DOWN)
results.AddValue(v0)
results.DidRunPage(self._page_set[0])
@@ -62,7 +64,8 @@ class JsonOutputFormatterTest(unittest.TestCase):
def testAsDictWithOnePage(self):
results = page_test_results.PageTestResults()
results.WillRunPage(self._page_set[0])
- v0 = scalar.ScalarValue(results.current_page, 'foo', 'seconds', 3)
+ v0 = scalar.ScalarValue(results.current_page, 'foo', 'seconds', 3,
+ improvement_direction=improvement_direction.DOWN)
results.AddValue(v0)
results.DidRunPage(self._page_set[0])
@@ -100,12 +103,14 @@ class JsonOutputFormatterTest(unittest.TestCase):
def testAsDictWithTwoPages(self):
results = page_test_results.PageTestResults()
results.WillRunPage(self._page_set[0])
- v0 = scalar.ScalarValue(results.current_page, 'foo', 'seconds', 3)
+ v0 = scalar.ScalarValue(results.current_page, 'foo', 'seconds', 3,
+ improvement_direction=improvement_direction.DOWN)
results.AddValue(v0)
results.DidRunPage(self._page_set[0])
results.WillRunPage(self._page_set[1])
- v1 = scalar.ScalarValue(results.current_page, 'bar', 'seconds', 4)
+ v1 = scalar.ScalarValue(results.current_page, 'bar', 'seconds', 4,
+ improvement_direction=improvement_direction.DOWN)
results.AddValue(v1)
results.DidRunPage(self._page_set[1])
@@ -119,7 +124,8 @@ class JsonOutputFormatterTest(unittest.TestCase):
def testAsDictWithSummaryValueOnly(self):
results = page_test_results.PageTestResults()
- v = scalar.ScalarValue(None, 'baz', 'seconds', 5)
+ v = scalar.ScalarValue(None, 'baz', 'seconds', 5,
+ improvement_direction=improvement_direction.DOWN)
results.AddSummaryValue(v)
d = json_output_formatter.ResultsAsDict(results,

Powered by Google App Engine
This is Rietveld 408576698