Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/telemetry/telemetry/results/page_test_results_unittest.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix linter issues Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/results/page_run_unittest.py ('k') | tools/telemetry/telemetry/user_story/user_story_runner_unittest.py » ('j') | tools/telemetry/telemetry/value/scalar.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/results/page_test_results_unittest.py
diff --git a/tools/telemetry/telemetry/results/page_test_results_unittest.py b/tools/telemetry/telemetry/results/page_test_results_unittest.py
index 536cdc84b0581aa684f538a284c6429decf2ce18..c9fde58dd037971d24454c54f492bff344cf3004 100644
--- a/tools/telemetry/telemetry/results/page_test_results_unittest.py
+++ b/tools/telemetry/telemetry/results/page_test_results_unittest.py
@@ -11,6 +11,7 @@ from telemetry.results import page_test_results
from telemetry.timeline import trace_data
from telemetry.value import failure
from telemetry.value import histogram
+from telemetry.value import improvement_direction
from telemetry.value import scalar
from telemetry.value import skip
from telemetry.value import trace
@@ -66,11 +67,15 @@ class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):
def test_basic(self):
results = page_test_results.PageTestResults()
results.WillRunPage(self.pages[0])
- results.AddValue(scalar.ScalarValue(self.pages[0], 'a', 'seconds', 3))
+ results.AddValue(scalar.ScalarValue(
+ self.pages[0], 'a', 'seconds', 3,
+ improvement_direction=improvement_direction.DOWN))
results.DidRunPage(self.pages[0])
results.WillRunPage(self.pages[1])
- results.AddValue(scalar.ScalarValue(self.pages[1], 'a', 'seconds', 3))
+ results.AddValue(scalar.ScalarValue(
+ self.pages[1], 'a', 'seconds', 3,
+ improvement_direction=improvement_direction.DOWN))
results.DidRunPage(self.pages[1])
results.PrintSummary()
@@ -90,32 +95,39 @@ class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):
self.assertRaises(
AssertionError,
lambda: results.AddValue(scalar.ScalarValue(
- self.pages[0], 'url', 'string', 'foo')))
+ self.pages[0], 'url', 'string', 'foo',
+ improvement_direction=improvement_direction.DOWN)))
def test_add_summary_value_with_page_specified(self):
results = page_test_results.PageTestResults()
results.WillRunPage(self.pages[0])
self.assertRaises(
AssertionError,
- lambda: results.AddSummaryValue(scalar.ScalarValue(self.pages[0],
- 'a', 'units', 3)))
+ lambda: results.AddSummaryValue(scalar.ScalarValue(
+ self.pages[0], 'a', 'units', 3,
+ improvement_direction=improvement_direction.DOWN)))
def test_unit_change(self):
results = page_test_results.PageTestResults()
results.WillRunPage(self.pages[0])
- results.AddValue(scalar.ScalarValue(self.pages[0], 'a', 'seconds', 3))
+ results.AddValue(scalar.ScalarValue(
+ self.pages[0], 'a', 'seconds', 3,
+ improvement_direction=improvement_direction.DOWN))
results.DidRunPage(self.pages[0])
results.WillRunPage(self.pages[1])
self.assertRaises(
AssertionError,
lambda: results.AddValue(scalar.ScalarValue(
- self.pages[1], 'a', 'foobgrobbers', 3)))
+ self.pages[1], 'a', 'foobgrobbers', 3,
+ improvement_direction=improvement_direction.DOWN)))
def test_type_change(self):
results = page_test_results.PageTestResults()
results.WillRunPage(self.pages[0])
- results.AddValue(scalar.ScalarValue(self.pages[0], 'a', 'seconds', 3))
+ results.AddValue(scalar.ScalarValue(
+ self.pages[0], 'a', 'seconds', 3,
+ improvement_direction=improvement_direction.DOWN))
results.DidRunPage(self.pages[0])
results.WillRunPage(self.pages[1])
@@ -123,17 +135,22 @@ class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):
AssertionError,
lambda: results.AddValue(histogram.HistogramValue(
self.pages[1], 'a', 'seconds',
- raw_value_json='{"buckets": [{"low": 1, "high": 2, "count": 1}]}')))
+ raw_value_json='{"buckets": [{"low": 1, "high": 2, "count": 1}]}',
+ improvement_direction=improvement_direction.DOWN)))
def test_get_pages_that_succeeded_all_pages_fail(self):
results = page_test_results.PageTestResults()
results.WillRunPage(self.pages[0])
- results.AddValue(scalar.ScalarValue(self.pages[0], 'a', 'seconds', 3))
+ results.AddValue(scalar.ScalarValue(
+ self.pages[0], 'a', 'seconds', 3,
+ improvement_direction=improvement_direction.DOWN))
results.AddValue(failure.FailureValue.FromMessage(self.pages[0], 'message'))
results.DidRunPage(self.pages[0])
results.WillRunPage(self.pages[1])
- results.AddValue(scalar.ScalarValue(self.pages[1], 'a', 'seconds', 7))
+ results.AddValue(scalar.ScalarValue(
+ self.pages[1], 'a', 'seconds', 7,
+ improvement_direction=improvement_direction.DOWN))
results.AddValue(failure.FailureValue.FromMessage(self.pages[1], 'message'))
results.DidRunPage(self.pages[1])
@@ -143,24 +160,32 @@ class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):
def test_get_successful_page_values_merged_no_failures(self):
results = page_test_results.PageTestResults()
results.WillRunPage(self.pages[0])
- results.AddValue(scalar.ScalarValue(self.pages[0], 'a', 'seconds', 3))
+ results.AddValue(scalar.ScalarValue(
+ self.pages[0], 'a', 'seconds', 3,
+ improvement_direction=improvement_direction.DOWN))
self.assertEquals(1, len(results.all_page_specific_values))
results.DidRunPage(self.pages[0])
def test_get_all_values_for_successful_pages(self):
results = page_test_results.PageTestResults()
results.WillRunPage(self.pages[0])
- value1 = scalar.ScalarValue(self.pages[0], 'a', 'seconds', 3)
+ value1 = scalar.ScalarValue(
+ self.pages[0], 'a', 'seconds', 3,
+ improvement_direction=improvement_direction.DOWN)
results.AddValue(value1)
results.DidRunPage(self.pages[0])
results.WillRunPage(self.pages[1])
- value2 = scalar.ScalarValue(self.pages[1], 'a', 'seconds', 3)
+ value2 = scalar.ScalarValue(
+ self.pages[1], 'a', 'seconds', 3,
+ improvement_direction=improvement_direction.DOWN)
results.AddValue(value2)
results.DidRunPage(self.pages[1])
results.WillRunPage(self.pages[2])
- value3 = scalar.ScalarValue(self.pages[2], 'a', 'seconds', 3)
+ value3 = scalar.ScalarValue(
+ self.pages[2], 'a', 'seconds', 3,
+ improvement_direction=improvement_direction.DOWN)
results.AddValue(value3)
results.DidRunPage(self.pages[2])
@@ -170,7 +195,9 @@ class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):
def test_get_all_values_for_successful_pages_one_page_fails(self):
results = page_test_results.PageTestResults()
results.WillRunPage(self.pages[0])
- value1 = scalar.ScalarValue(self.pages[0], 'a', 'seconds', 3)
+ value1 = scalar.ScalarValue(
+ self.pages[0], 'a', 'seconds', 3,
+ improvement_direction=improvement_direction.DOWN)
results.AddValue(value1)
results.DidRunPage(self.pages[0])
@@ -180,7 +207,9 @@ class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):
results.DidRunPage(self.pages[1])
results.WillRunPage(self.pages[2])
- value3 = scalar.ScalarValue(self.pages[2], 'a', 'seconds', 3)
+ value3 = scalar.ScalarValue(
+ self.pages[2], 'a', 'seconds', 3,
+ improvement_direction=improvement_direction.DOWN)
results.AddValue(value3)
results.DidRunPage(self.pages[2])
« no previous file with comments | « tools/telemetry/telemetry/results/page_run_unittest.py ('k') | tools/telemetry/telemetry/user_story/user_story_runner_unittest.py » ('j') | tools/telemetry/telemetry/value/scalar.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698