Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Side by Side Diff: tools/telemetry/telemetry/results/page_run_unittest.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix linter issues Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import os 5 import os
6 import unittest 6 import unittest
7 7
8 from telemetry import page as page_module 8 from telemetry import page as page_module
9 from telemetry.page import page_set 9 from telemetry.page import page_set
10 from telemetry.results import page_run 10 from telemetry.results import page_run
11 from telemetry.value import failure 11 from telemetry.value import failure
12 from telemetry.value import improvement_direction
12 from telemetry.value import scalar 13 from telemetry.value import scalar
13 from telemetry.value import skip 14 from telemetry.value import skip
14 15
15 16
16 class PageRunTest(unittest.TestCase): 17 class PageRunTest(unittest.TestCase):
17 def setUp(self): 18 def setUp(self):
18 self.page_set = page_set.PageSet(file_path=os.path.dirname(__file__)) 19 self.page_set = page_set.PageSet(file_path=os.path.dirname(__file__))
19 self.page_set.AddUserStory(page_module.Page( 20 self.page_set.AddUserStory(page_module.Page(
20 'http://www.bar.com/', self.page_set, self.page_set.base_dir)) 21 'http://www.bar.com/', self.page_set, self.page_set.base_dir))
21 22
22 @property 23 @property
23 def pages(self): 24 def pages(self):
24 return self.page_set.pages 25 return self.page_set.pages
25 26
26 def testPageRunFailed(self): 27 def testPageRunFailed(self):
27 run = page_run.PageRun(self.pages[0]) 28 run = page_run.PageRun(self.pages[0])
28 run.AddValue(failure.FailureValue.FromMessage(self.pages[0], 'test')) 29 run.AddValue(failure.FailureValue.FromMessage(self.pages[0], 'test'))
29 self.assertFalse(run.ok) 30 self.assertFalse(run.ok)
30 self.assertTrue(run.failed) 31 self.assertTrue(run.failed)
31 self.assertFalse(run.skipped) 32 self.assertFalse(run.skipped)
32 33
33 run = page_run.PageRun(self.pages[0]) 34 run = page_run.PageRun(self.pages[0])
34 run.AddValue(scalar.ScalarValue(self.pages[0], 'a', 's', 1)) 35 run.AddValue(scalar.ScalarValue(
36 self.pages[0], 'a', 's', 1,
37 improvement_direction=improvement_direction.DOWN))
35 run.AddValue(failure.FailureValue.FromMessage(self.pages[0], 'test')) 38 run.AddValue(failure.FailureValue.FromMessage(self.pages[0], 'test'))
36 self.assertFalse(run.ok) 39 self.assertFalse(run.ok)
37 self.assertTrue(run.failed) 40 self.assertTrue(run.failed)
38 self.assertFalse(run.skipped) 41 self.assertFalse(run.skipped)
39 42
40 def testPageRunSkipped(self): 43 def testPageRunSkipped(self):
41 run = page_run.PageRun(self.pages[0]) 44 run = page_run.PageRun(self.pages[0])
42 run.AddValue(failure.FailureValue.FromMessage(self.pages[0], 'test')) 45 run.AddValue(failure.FailureValue.FromMessage(self.pages[0], 'test'))
43 run.AddValue(skip.SkipValue(self.pages[0], 'test')) 46 run.AddValue(skip.SkipValue(self.pages[0], 'test'))
44 self.assertFalse(run.ok) 47 self.assertFalse(run.ok)
45 self.assertFalse(run.failed) 48 self.assertFalse(run.failed)
46 self.assertTrue(run.skipped) 49 self.assertTrue(run.skipped)
47 50
48 run = page_run.PageRun(self.pages[0]) 51 run = page_run.PageRun(self.pages[0])
49 run.AddValue(scalar.ScalarValue(self.pages[0], 'a', 's', 1)) 52 run.AddValue(scalar.ScalarValue(
53 self.pages[0], 'a', 's', 1,
54 improvement_direction=improvement_direction.DOWN))
50 run.AddValue(skip.SkipValue(self.pages[0], 'test')) 55 run.AddValue(skip.SkipValue(self.pages[0], 'test'))
51 self.assertFalse(run.ok) 56 self.assertFalse(run.ok)
52 self.assertFalse(run.failed) 57 self.assertFalse(run.failed)
53 self.assertTrue(run.skipped) 58 self.assertTrue(run.skipped)
54 59
55 def testPageRunSucceeded(self): 60 def testPageRunSucceeded(self):
56 run = page_run.PageRun(self.pages[0]) 61 run = page_run.PageRun(self.pages[0])
57 self.assertTrue(run.ok) 62 self.assertTrue(run.ok)
58 self.assertFalse(run.failed) 63 self.assertFalse(run.failed)
59 self.assertFalse(run.skipped) 64 self.assertFalse(run.skipped)
60 65
61 run = page_run.PageRun(self.pages[0]) 66 run = page_run.PageRun(self.pages[0])
62 run.AddValue(scalar.ScalarValue(self.pages[0], 'a', 's', 1)) 67 run.AddValue(scalar.ScalarValue(
68 self.pages[0], 'a', 's', 1,
69 improvement_direction=improvement_direction.DOWN))
63 self.assertTrue(run.ok) 70 self.assertTrue(run.ok)
64 self.assertFalse(run.failed) 71 self.assertFalse(run.failed)
65 self.assertFalse(run.skipped) 72 self.assertFalse(run.skipped)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698