Change desktop and ES 3.0 to always use sized internal texture formats.

Change desktop and ES 3.0 to always use sized internal texture formats.

Committed: https://skia.googlesource.com/skia/+/bc02bf0ee4221604796cd6d0394ca3af60c0a579

Committed: https://skia.googlesource.com/skia/+/3f801cbb67895fa9fa29498aa017a7666960a627

[jvanverth1, 2014-12-15 21:56:13]

jvanverth@google.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2014-12-15 22:20:00]

https://codereview.chromium.org/806943002/diff/1/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (right):

https://codereview.chromium.org/806943002/diff/1/src/gpu/gl/GrGpuGL.cpp#newco...
src/gpu/gl/GrGpuGL.cpp:562: bool useSizedFormat = useTexStorage;
maybe just change to usf = useTexStorage || glstd == gl || ver > 3.0

lgtm

[jvanverth1, 2014-12-16 13:35:16]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2014-12-16 13:35:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/806943002/20001

[commit-bot: I haz the power, 2014-12-16 13:45:54]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/bc02bf0ee4221604796cd6d0394ca3af60c0a579

[jvanverth1, 2014-12-16 14:17:14]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/805193003/ by jvanverth@google.com.

The reason for reverting is: Failing GMs on Mac, Windows and Ubuntu12..

[jvanverth1, 2014-12-16 15:13:29]

Another pass, this time with ES2 compatibility added.

[bsalomon, 2014-12-16 15:28:18]

https://codereview.chromium.org/806943002/diff/40001/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (right):

https://codereview.chromium.org/806943002/diff/40001/src/gpu/gl/GrGpuGL.cpp#n...
src/gpu/gl/GrGpuGL.cpp:2166: if (this->glStandard() == kGL_GrGLStandard &&
won't this check happen in line 2130?

[jvanverth1, 2014-12-16 15:32:38]

On 2014/12/16 15:28:18, bsalomon wrote:
> https://codereview.chromium.org/806943002/diff/40001/src/gpu/gl/GrGpuGL.cpp
> File src/gpu/gl/GrGpuGL.cpp (right):
> 
>
https://codereview.chromium.org/806943002/diff/40001/src/gpu/gl/GrGpuGL.cpp#n...
> src/gpu/gl/GrGpuGL.cpp:2166: if (this->glStandard() == kGL_GrGLStandard &&
> won't this check happen in line 2130?

Done.

[bsalomon, 2014-12-16 16:11:41]

On 2014/12/16 15:32:38, jvanverth1 wrote:
> On 2014/12/16 15:28:18, bsalomon wrote:
> > https://codereview.chromium.org/806943002/diff/40001/src/gpu/gl/GrGpuGL.cpp
> > File src/gpu/gl/GrGpuGL.cpp (right):
> > 
> >
>
https://codereview.chromium.org/806943002/diff/40001/src/gpu/gl/GrGpuGL.cpp#n...
> > src/gpu/gl/GrGpuGL.cpp:2166: if (this->glStandard() == kGL_GrGLStandard &&
> > won't this check happen in line 2130?
> 
> Done.

lgtm, but do you want to land as is or change to use GL_RGB5?

[jvanverth1, 2014-12-16 16:19:02]

On 2014/12/16 16:11:41, bsalomon wrote:
> On 2014/12/16 15:32:38, jvanverth1 wrote:
> > On 2014/12/16 15:28:18, bsalomon wrote:
> > >
https://codereview.chromium.org/806943002/diff/40001/src/gpu/gl/GrGpuGL.cpp
> > > File src/gpu/gl/GrGpuGL.cpp (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/806943002/diff/40001/src/gpu/gl/GrGpuGL.cpp#n...
> > > src/gpu/gl/GrGpuGL.cpp:2166: if (this->glStandard() == kGL_GrGLStandard &&
> > > won't this check happen in line 2130?
> > 
> > Done.
> 
> lgtm, but do you want to land as is or change to use GL_RGB5?

Added the GL_RGB5 support.

[bsalomon, 2014-12-16 16:33:09]

On 2014/12/16 16:19:02, jvanverth1 wrote:
> On 2014/12/16 16:11:41, bsalomon wrote:
> > On 2014/12/16 15:32:38, jvanverth1 wrote:
> > > On 2014/12/16 15:28:18, bsalomon wrote:
> > > >
> https://codereview.chromium.org/806943002/diff/40001/src/gpu/gl/GrGpuGL.cpp
> > > > File src/gpu/gl/GrGpuGL.cpp (right):
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/806943002/diff/40001/src/gpu/gl/GrGpuGL.cpp#n...
> > > > src/gpu/gl/GrGpuGL.cpp:2166: if (this->glStandard() == kGL_GrGLStandard
&&
> > > > won't this check happen in line 2130?
> > > 
> > > Done.
> > 
> > lgtm, but do you want to land as is or change to use GL_RGB5?
> 
> Added the GL_RGB5 support.

lbtm

[jvanverth1, 2014-12-16 16:40:32]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2014-12-16 16:41:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/806943002/100001

[commit-bot: I haz the power, 2014-12-16 16:43:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-16 16:43:21]

Try jobs failed on following builders:
  Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GC...)

[jvanverth1, 2014-12-16 17:39:49]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2014-12-16 17:40:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/806943002/190001

[commit-bot: I haz the power, 2014-12-16 17:49:43]

Committed patchset #11 (id:190001) as
https://skia.googlesource.com/skia/+/3f801cbb67895fa9fa29498aa017a7666960a627